New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve quote content #12122

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Nov 20, 2018

closes #10456

Description

Ensure content we can't handle is preserved in HTML block.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@iseulde iseulde added this to the 4.5 milestone Nov 20, 2018

@iseulde iseulde requested a review from WordPress/gutenberg-core Nov 20, 2018

@youknowriad

It does make sense for me to only convert if the quote block supports the content. (If it's only paragraphs inside the quote)

@youknowriad youknowriad merged commit c97cec8 into master Nov 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the try/preserve-quote branch Nov 20, 2018

daniloercoli added a commit that referenced this pull request Nov 20, 2018

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/wire-on-replace-para-block

* 'master' of https://github.com/WordPress/gutenberg:
  Remove "permalink settings" link from permalink panel. (#12121)
  preserve quote content (#12122)
  Replace gutenberg domain with default for Core blocks (#12108)
  Fix issue with disabled togglecontrol double border (#12091)
  Fix the TinyMCE init array (#10968)

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Nov 22, 2018

preserve quote content (WordPress#12122)
* preserve quote content

* Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment