New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include :visited links in button color #12183

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
5 participants
@m-e-h
Copy link
Contributor

m-e-h commented Nov 21, 2018

Description

I noticed the underscores theme's :visited link color was overriding our button color.

I also made the outline button's transparent background specific to the background-color so it wouldn't overwrite other background properties. For example a background-image: linear-gradient() on hover.

How has this been tested?

visual tests with default themes and _s.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Include :visited links in button color
I noticed the underscores theme's `:visited` link color was overriding our button color.

I also made the outline button's transparent background specific to the background-color so it wouldn't overwrite other background properties. For example a `background-image: linear-gradient()` on hover.

@chrisvanpatten chrisvanpatten requested a review from jasmussen Nov 21, 2018

@chrisvanpatten
Copy link
Member

chrisvanpatten left a comment

This looks good to me, might want to wait for @jasmussen to give a second opinion though 👍

@chrisvanpatten

This comment has been minimized.

Copy link
Member

chrisvanpatten commented Nov 21, 2018

(Travis failure seems unrelated; I restarted the build)

@jasmussen
Copy link
Contributor

jasmussen left a comment

This seems good to me. Thank you!

@jasmussen jasmussen added this to the WordPress 5.0.x Follow Ups milestone Nov 22, 2018

@gziolo gziolo modified the milestones: WordPress 5.x, 5.0 (Gutenberg) Jan 25, 2019

@gziolo gziolo merged commit c89de50 into WordPress:master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

daniloercoli added a commit that referenced this pull request Jan 26, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-enter-key-detection-to-title

* 'master' of https://github.com/WordPress/gutenberg: (29 commits)
  Update for RangeControl documentation (#12564)
  Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456)
  Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488)
  Replace the fullscreen "exit" icon with a back arrow (#13403)
  Include :visited links in button color (#12183)
  Amazon Kindle block (#13510)
  Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457)
  Add watcher on Linux: change fs to node-watch (#13448)
  Plugin: Deprecate `gutenberg` theme support (#13458)
  Datepicker: Add inValidDay support (#12962)
  Block Switcher: Render disabled button even if multi-selection (#13431)
  Plugin: Deprecate gutenberg_register_post_types (#13468)
  Plugin: Deprecate register_tinymce_scripts (#13466)
  Set minimum of words for RSS excerpt (#13502)
  Plugin: Deprecate gutenberg_get_block_categories (#13454)
  Plugin: Deprecate gutenberg_content_block_version (#13469)
  API Fetch: Expose nonce on created middleware function (#13451)
  Plugin: Remove list screens integrations (#13459)
  Plugin: Remove core-defined block detection functions (#13467)
  Spec Parser: Move generated spec parser to package (#13493)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment