New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cover block placeholder background color #12187

Merged
merged 1 commit into from Nov 21, 2018

Conversation

@desrosj
Contributor

desrosj commented Nov 21, 2018

Prevent the components package styles from overriding the cover block background color.

Fixes #12179.
Related: Trac-45279.

For details on how to reproduce the issue, see #12179.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [ ] My code follows the accessibility standards.
  • [ ] My code has proper inline documentation.
@jorgefilipecosta

Thank you for your contribution @desrosj this change fixes the problem in my tests. But it exposes another existing problem, the styles &.components-placeholder should not exist in style.scss but in editor.scss as this rule is not needed on the frontend of the websites. I will follow up with a PR that addresses the problem for this block.

@jorgefilipecosta jorgefilipecosta merged commit 43bb1ed into WordPress:master Nov 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@desrosj desrosj deleted the desrosj:fix/12179-cover-block-prevent-black-background branch Nov 21, 2018

@noisysocks noisysocks added this to the 4.5.2 milestone Nov 22, 2018

jorgefilipecosta added a commit that referenced this pull request Nov 23, 2018

Fix: Cover Block: Move some editor specific styles from style.scss to…
… editor.scss (#12236)

During the reviews of #12187 we found out that the cover block contains some editor specific styles on the front end.
This is a problem because we would be transferring bytes on the frontend of websites that are not used at all.
This PR just moves this styles to editor.scss so they are loaded only in the editor.


## How has this been tested?
I checked that there was no noticeable change on the cover block (and its placeholder).

youknowriad added a commit that referenced this pull request Nov 29, 2018

Fix: Cover Block: Move some editor specific styles from style.scss to…
… editor.scss (#12236)

During the reviews of #12187 we found out that the cover block contains some editor specific styles on the front end.
This is a problem because we would be transferring bytes on the frontend of websites that are not used at all.
This PR just moves this styles to editor.scss so they are loaded only in the editor.


## How has this been tested?
I checked that there was no noticeable change on the cover block (and its placeholder).

@mtias mtias added this to the 4.6 milestone Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment