New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button block styles and wrap. #12205

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
5 participants
@jasmussen
Contributor

jasmussen commented Nov 22, 2018

This PR fixes #7843, and also simplifies the styles a bit. It also fixes an overflow issue with long text in variations. Finally, it makes a single line button have a proper pillshape.

Before:

screenshot 2018-11-22 at 09 52 53

screenshot 2018-11-22 at 09 53 36

After:

screenshot 2018-11-22 at 10 04 03

screenshot 2018-11-22 at 09 59 59

Improve button block styles and wrap.
This PR fixes #7843, and also simplifies the styles a bit. It also fixes an overflow issue with long text in variations. Finally, it makes a single line button have a proper pillshape.

@jasmussen jasmussen added this to the WordPress 5.0.x Follow Ups milestone Nov 22, 2018

@jasmussen jasmussen self-assigned this Nov 22, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Nov 22, 2018

@jorgefilipecosta

I did some tests and I did not find any problem with the new styles 👍 The code changes make sense.

@mtias mtias modified the milestones: WordPress 5.0.x Follow Ups, 4.7 Nov 22, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Nov 23, 2018

Same as with #12212 (comment), I'm leaving unmerged as I'm unsure when the correct time to merge is. Feel free to merge if the time is right.

@youknowriad youknowriad merged commit 1f57485 into master Nov 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/button-wrap branch Nov 23, 2018

@ZebulanStanphill

This comment has been minimized.

Contributor

ZebulanStanphill commented Nov 28, 2018

Should this be moved out of the "4.7" and "WordPress 5.0.x Follow Ups" milestones and into the "4.6" milestone?

@mtias mtias modified the milestones: 4.7, 4.6 Nov 28, 2018

@mtias

This comment has been minimized.

Contributor

mtias commented Nov 28, 2018

Yes.

youknowriad added a commit that referenced this pull request Nov 29, 2018

Improve button block styles and wrap. (#12205)
This PR fixes #7843, and also simplifies the styles a bit. It also fixes an overflow issue with long text in variations. Finally, it makes a single line button have a proper pillshape.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment