New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve block preview. #12212

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Nov 22, 2018

Hopefully fixes #11997.

It polishes the preview code a bit to be leaner and more readable. But mostly it adds a fwe CSS style overrides that it might inherit from the theme.

CC: @m-e-h

screenshot 2018-11-22 at 11 10 07

screenshot 2018-11-22 at 11 11 00

screenshot 2018-11-22 at 11 11 15

screenshot 2018-11-22 at 11 11 23

screenshot 2018-11-22 at 11 11 38

Improve block preview.
Hopefully fixes #11997.

It polishes the preview code a bit to be leaner and more readable. But mostly it adds a fwe CSS style overrides that it might inherit from the theme.

@jasmussen jasmussen added this to the WordPress 5.0.x Follow Ups milestone Nov 22, 2018

@jasmussen jasmussen self-assigned this Nov 22, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Nov 22, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Nov 22, 2018

I'm leaving unmerged as I'm not quite sure, at this point in time, whether and when is a good time to merge. Feel free to merge & milestone if it should go in now.

@mtias mtias modified the milestones: WordPress 5.0.x Follow Ups, 4.6 Nov 22, 2018

@youknowriad youknowriad merged commit 70b378b into master Nov 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the try/editor-styles-wrapper-preview branch Nov 23, 2018

@mtias mtias added the Blocks label Nov 29, 2018

youknowriad added a commit that referenced this pull request Nov 29, 2018

Improve block preview. (#12212)
Hopefully fixes #11997.

It polishes the preview code a bit to be leaner and more readable. But mostly it adds a fwe CSS style overrides that it might inherit from the theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment