New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sentence case in toolbar tooltips #12239

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@dimadin
Copy link
Contributor

dimadin commented Nov 22, 2018

As discussed in #11708 with @gziolo, this PR changes instances where Title Case is used in toolbar tooltips to use Sentence case.

I've tested all blocks, and found that Title Case is used only in one more instance: for List View/Grid View in Latest Posts block.

screen shot 2018-11-22 at 22 33 41

This seems inconsistent with other blocks, should this be converted to styles, should we change strings to Convert to list view/Convert to grid view, or should we just change case?

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Nov 26, 2018

Thanks for opening a follow-up PR. This fix looks okey but I will leave it to others to decide what is the best way to move forward.

@michelleweber

This comment has been minimized.

Copy link

michelleweber commented Nov 26, 2018

Yes, I would change these to sentence case.

@gziolo

gziolo approved these changes Jan 25, 2019

Copy link
Member

gziolo left a comment

Thanks for making it consistent. Nice work 👍

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 25, 2019

@gziolo gziolo merged commit 40e79d5 into WordPress:master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment