New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modals in Edge. #12241

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Nov 23, 2018

This PR fixes #11585.

Edge has a buggy implementation of position: sticky;, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/.

This is mainly an issue in deeply nested elements, it seems.

This PR includes an edge only hack that overrides the sticky and uses position: fixed; instead.

JIFs, Edge:

edge modals

IE 11:

ie modals

Chrome, Mac:

chrome mac

Safari, Mac:

safari mac

Firefox, Mac:

firefox mac

Fix modals in Edge.
This PR fixes #11585.

Edge has a buggy implementation of `position: sticky;`, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/.

This is mainly an issue in deeply nested elements, it seems.

This PR includes an edge only hack that overrides the sticky and uses `position: fixed;` instead.

@jasmussen jasmussen self-assigned this Nov 23, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Nov 23, 2018

@tofumatt

Coolio, thanks!

@@ -66,13 +66,20 @@
justify-content: space-between;
background: $white;
align-items: center;
box-sizing: border-box;

This comment has been minimized.

@tofumatt

tofumatt Nov 23, 2018

Member

Was this just not needed anymore? It doesn’t seem related to the other changes.

This comment has been minimized.

@jasmussen

jasmussen Nov 23, 2018

Contributor

Yes, good catch, I should've noted that as a code comment. Turns out that rule was written out twice in the same rule. Here it is on line 61, still there:

box-sizing: border-box;

Thank you for the review.

@jasmussen jasmussen added this to the 4.6 milestone Nov 23, 2018

@jasmussen jasmussen merged commit 5aacd90 into master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/edge-modal branch Nov 27, 2018

dd32 added a commit to dd32/gutenberg that referenced this pull request Nov 29, 2018

Fix modals in Edge. (WordPress#12241)
This PR fixes WordPress#11585.

Edge has a buggy implementation of `position: sticky;`, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/.

This is mainly an issue in deeply nested elements, it seems.

This PR includes an edge only hack that overrides the sticky and uses `position: fixed;` instead.

youknowriad added a commit that referenced this pull request Nov 29, 2018

Fix modals in Edge. (#12241)
This PR fixes #11585.

Edge has a buggy implementation of `position: sticky;`, which includes issues with flickering, z-index, and parent container paddings. See more at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/17555420/.

This is mainly an issue in deeply nested elements, it seems.

This PR includes an edge only hack that overrides the sticky and uses `position: fixed;` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment