New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for css file before trying to read #12291

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@mkaz
Member

mkaz commented Nov 25, 2018

Matches existing core trac ticket: https://core.trac.wordpress.org/ticket/45288

Fixes #12196

Description

Adds a check to see if the css file exists before trying to read it.

How has this been tested?

  • Confirm everything still works
  • Confirm no error if style file does not exist

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Nov 25, 2018

@mkaz

This comment has been minimized.

Member

mkaz commented Nov 25, 2018

@youknowriad oops, I didn't see the other one. Updated, agreed it's simpler.

@youknowriad youknowriad merged commit 1ee2013 into master Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/12196/css-file-check branch Nov 26, 2018

@youknowriad youknowriad added this to the 4.6 milestone Nov 29, 2018

youknowriad added a commit that referenced this pull request Nov 29, 2018

Add check for css file before trying to read (#12291)
* Add check for css file before trying to read

Mirrors existing trac ticket https://core.trac.wordpress.org/ticket/45288

Fixes #12196

* Use other patch :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment