New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Apply IE11 input fix only when mounting TinyMCE #12335

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@aduth
Member

aduth commented Nov 26, 2018

Related: #12234 (comment)

This pull request seeks to resolve an error which will occur when unmounting an instance of the RichText component in IE11. As of #12234, the ref callback handler was not accounting for the null value being passed during unmounting of the component, thus resulting in errors when subsequent logic would attempt to reference properties as if it were an DOM node.

React will call the ref callback with the DOM element when the component mounts, and call it with null when it unmounts.

https://reactjs.org/docs/refs-and-the-dom.html#callback-refs

Testing instructions:

In Internet Explorer 11 and your preferred browser, ensure that no errors are logged when removing a paragraph block:

  1. Navigate to Posts > Add New
  2. Click the writing prompt
  3. Press Backspace

@aduth aduth requested a review from iseulde Nov 26, 2018

@aduth aduth referenced this pull request Nov 26, 2018

Merged

Add IE check for IE fix #12234

4 of 4 tasks complete

@aduth aduth merged commit 640b2ff into master Nov 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the fix/tinymce-ie11-unmount-error branch Nov 27, 2018

dd32 added a commit to dd32/gutenberg that referenced this pull request Nov 29, 2018

@youknowriad youknowriad added this to the 4.6 milestone Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment