New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only initialise TinyMCE once per instance #12386

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@iseulde
Copy link
Member

iseulde commented Nov 28, 2018

Description

Currently we're trying to initialise TinyMCE every time the content editable element receives focus.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@iseulde iseulde requested review from youknowriad and WordPress/gutenberg-core Nov 28, 2018

initialize() {
if ( this.initialize.called ) {

This comment has been minimized.

@youknowriad

youknowriad Nov 28, 2018

Contributor

Why not just this.initialized 🤷‍♂️

I find it a bit weird to attach a property to the method while we have access to the object but it's minor.

This comment has been minimized.

@iseulde

iseulde Nov 28, 2018

Member

It's local state. But I don't mind either way.

@youknowriad
Copy link
Contributor

youknowriad left a comment

LGTM 👍

@mtias mtias added this to the 4.7 milestone Nov 28, 2018

@iseulde

This comment has been minimized.

Copy link
Member

iseulde commented Nov 28, 2018

@mtias Removing the "[External Package] TinyMCE" as that's only for issue in TinyMCE.

@youknowriad youknowriad merged commit d30e5eb into master Nov 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/mce-init branch Nov 30, 2018

daniloercoli added a commit that referenced this pull request Nov 30, 2018

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/danilo-try-to-fix-undo-redo

* 'master' of https://github.com/WordPress/gutenberg:
  Autocompleters: Consider block category (#12287)
  Only init TinyMCE once per instance (#12386)
  RichText: convert HTML formatting whitespace to spaces (#12166)
  Notices: Remove "files" block in package.json (#12438)
  Edit Post: Avoid rendering AdminNotices compatibility component (#12444)
  Correct the docs manifest (#12411)

daniloercoli added a commit that referenced this pull request Nov 30, 2018

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…HEAD

* 'master' of https://github.com/WordPress/gutenberg:
  [RNmobile] Fix problems with undo/redo on Android (#12417)
  Add registry param to withDispatch component (#11851)
  Autocompleters: Consider block category (#12287)
  Only init TinyMCE once per instance (#12386)
  RichText: convert HTML formatting whitespace to spaces (#12166)
  Notices: Remove "files" block in package.json (#12438)
  Edit Post: Avoid rendering AdminNotices compatibility component (#12444)
  Correct the docs manifest (#12411)

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment