Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Try fixing the tab navigation issue #12390
Nov 28, 2018
1 check passed
Thanks a million for getting to this while I stepped away from my Mac for a few hours!
I would certainly like to see this in the WordPress 5.0 release, are others cool with seeing it in? I don't think it's mandatory (I didn't consider it a blocker per se) but it's certainly a low-risk code-wise to me for a significant win.
What's the process for patching RC at this point? Is it just to merge it into master like was done and then cut a patch release for 4.6 that Core will use?
referenced this pull request
Nov 28, 2018
I thought anything that gets committed in 4.6 is meant to be merged in WP 5.0?
I think the idea would be something like a 4.5.2, based on that Slack discussion, would have fixes like this cherry-picked if approved by the release lead (@m). I think all commits against 5.0 now need to go through the appropriate release lead (for a11y, me) and @pento or @m: https://wordpress.slack.com/archives/C02RQBWTW/p1542966281138400
I think this would be worth including as the fix is low-risk for high-reward.