Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Editor: Fix regression introduced in CopyHandler #12543
Regression introduced in #11851.
Reported by @afercia:
Initially, I tried to fix it by returning the information whether copy handler override was triggered but it is not possible to return a value from the dispatch handler exposed by
I ended up with moving
How has this been tested?
All of that should basically work.
Sadly, it looks like it isn't possible to add e2e tests which would prevent this regression in the future. Such tests would only work when puppeteer operates with a real browser. It won't work in the headless mode which is the most expected way of running those tests. A related issue where this limiation is explained #2147.
referenced this pull request
Dec 3, 2018
left a comment
Another implementation which might be preferable is that the event handlers are bound and unbound in response to the change in condition applying. i.e. we don't bind on mount, but rather when the
For the purposes of resolving the regression, I'm fine with the general approach here. I think the main blocker for me would be the reference of