New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a post is saved, check for tinymce and save any editors. #12568

Merged
merged 8 commits into from Dec 9, 2018

Conversation

Projects
None yet
5 participants
@ideadude
Copy link
Contributor

ideadude commented Dec 3, 2018

Description

This is an alternative fix to this PR: #12363

The other pull request imported tinymce and ran tinymce.triggerSave(); but this wasn't actually saving the editor content in some cases.

This patch instead checks for window.tinymce and if found loops through the editors individually and calls the save() method of the editors. This will copy the tinymce editor content into the related textarea so the updated content is saved. Importantly, if the editor is on the text tab, the save method will NOT copy the tinymce content and instead leave the textarea as is. In other words, with this PR things are working as expected: the content from whichever tab (visual or text) that is visible will be saved.

Another note: this PR doesn't import the tinymce library or include the other updates the referenced PR had. This isn't needed, since we just use the window.tinymce object as is if it's found.

How has this been tested?

This was tested on WP 4.9.9-alpha-43656 and Chrome Version 70.0.3538.110 (Official Build) (64-bit). I tested on Firefox v63.

I tested this in a number of ways. I tested on new pages and posts. I tested updated the visual or text tabs. I tested with multiple editors from multiple plugins. I tested with the classic editor installed. I tested when saving a draft or publishing or clicking update.

All my tests passed.

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

(Note: There were other warnings in the file I changed that I ignored.)

  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@@ -72,6 +72,13 @@ const effects = {
} );
},
REQUEST_META_BOX_UPDATES( action, store ) {
// Saves the wp_editor fields
if ( window.tinymce ) {

This comment has been minimized.

@youknowriad

youknowriad Dec 4, 2018

Contributor

It will have the same effect but I'd use import tinymce from "tinymce" for consistency in how we use the tinymce module accross gutenberg.

This comment has been minimized.

@iseulde

iseulde Dec 4, 2018

Member

I'm not sure if this is the same. That will hold all the editor instances of all the rich text instances. window.tinymce holds the instances that were created by plugins and the classic block. Should this filter out classic block instances?

This comment has been minimized.

@iseulde

iseulde Dec 4, 2018

Member

E.g. in the classic block we set a property to editor and then check for it here.

This comment has been minimized.

@ideadude

ideadude Dec 4, 2018

Contributor

I updated the PR to import tinymce and use that vs the object stored in window.tinymce. This does have the effect of including the classic editor tinymce instances in .editors. Calling the save method on the classic block tinymce instances doesn't seem to have any adverse effects though (besides a minor performance hit). IMO it's not worth filtering them out.

This comment has been minimized.

@ideadude

ideadude Dec 4, 2018

Contributor

Going crazy here. I did a quick test of swapping back triggerSave vs the looping and it's working again. Going to do some more tests with the old PR to really figure out why that was failing for me sometimes again.

I'm afk for a couple hours, but will post an update soon. :D

This comment has been minimized.

@iseulde

iseulde Dec 4, 2018

Member

Because the meta boxes were added with window.tinymce? The nom module is only used for RichText instances. We don't want to include them here. window.tinymce.editors does not include the RichText TinyMCE instances.

This comment has been minimized.

@ideadude

ideadude Dec 4, 2018

Contributor

FYI my madness is that tinyMCE.triggerSave() --caps MCE-- works. The alternative PR had just tinymce.triggerSave() --lower mce-- which doesn't work.

I think using window.tinymce is safer with regards to the fix here. I feel like tinyMCE.editors was not always returning all of the added wp_editor boxes in some cases. Not sure the conditions.

This comment has been minimized.

@youknowriad

youknowriad Dec 4, 2018

Contributor

import tinymce from "tinymce" and window.tinymce are strictly equivalent according to our webpack config.

This comment has been minimized.

@ideadude

ideadude Dec 4, 2018

Contributor

FWIW, here is the code in core WordPress that makes sure we don't run save on editors on the text tab: https://github.com/WordPress/WordPress/blob/master/wp-includes/js/tinymce/plugins/wordpress/plugin.js#L605-L609

This comment has been minimized.

@iseulde

iseulde Dec 4, 2018

Member

You're right. I didn't see any rich text editor instances, so I thought they were different. Apparently rich text TinyMCE are not being added. Strange.

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Dec 4, 2018

Can we bring the package.json and changelog tweaks from https://github.com/WordPress/gutenberg/pull/12363/files too?

@iseulde
Copy link
Member

iseulde left a comment

This needs e2e tests.

@ideadude

This comment has been minimized.

Copy link
Contributor

ideadude commented Dec 4, 2018

Updated the version in package.json and changelog.md. Let me know if I did this incorrectly. I'm confused by the empty sections for certain versions in the changelog.md. Is there a write up on how these components are versioned?

3 options left for the actual code here:

  1. import tinymce and use tinyMCE.triggerSave()

  2. import tinymce and loop through tinyMCE.editors

  3. don't import tinymce and loop through window.tinymce.editors

Edit:

Adding a 4th that the current PR is using. Don't import tinymce, use tinyMCE.triggerSave()

A variation of this would be to use window.tinyMCE.triggerSave() to make sure we are talking about the "global" tinyMCE.

@@ -72,6 +73,11 @@ const effects = {
} );
},
REQUEST_META_BOX_UPDATES( action, store ) {
// Saves the wp_editor fields
for ( var i = 0; i < tinyMCE.editors.length; i++ ) {

This comment has been minimized.

@youknowriad

youknowriad Dec 4, 2018

Contributor

so this means you're loading the tinymce variable but using the tinyMCE global? seems to me like we should replace this with tinymce to use the imported variable?

This comment has been minimized.

@ideadude

ideadude Dec 4, 2018

Contributor

We can use the global tinyMCE without importing tinymce at the top.

If we import tinymce and call tinymce.triggerSave or tinymce.editors, they don't work as we would expect to save the extra editors.

Thanks again for the time on this. We're going to fix this issue, which is important for plugins. I'm getting an education in Gutenberg, node, and JS here. I apologize for the confusion.

This comment has been minimized.

@youknowriad

youknowriad Dec 4, 2018

Contributor

Thanks for your help here :). That's interesting though, now I'm curious. What is the difference between window.tinymce and window.tinyMCE?

This comment has been minimized.

@ideadude

ideadude Dec 4, 2018

Contributor

window.tinymce and window.tinyMCE seem to be the same object in my console (or 2 copies of the same object in sync). TinyMCE might setup both???

ideadude added some commits Dec 4, 2018

no longer importing tinymce since we use the tinyMCE global. tinyMCE.…
…triggerSave works now. checking if tinyMCE exists before making the call just in case.
@ideadude

This comment has been minimized.

Copy link
Contributor

ideadude commented Dec 6, 2018

This is ready to pull in IMO.

rilwis added a commit to wpmetabox/meta-box that referenced this pull request Dec 6, 2018

Fixed wysiwyg field not saving in Gutenberg.
Bug report: https://metabox.io/support/topic/data-are-not-saved-into-the-database/
Issue: WordPress/gutenberg#7176

The fix is based on CMB2 fix (CMB2/CMB2#1190) and the PR(WordPress/gutenberg#12568)

When the PR is merged into core/Gutenberg, this fix should be removed.
@@ -1,6 +1,6 @@
{
"name": "@wordpress/edit-post",
"version": "3.1.4",
"version": "3.1.5",

This comment has been minimized.

@youknowriad

youknowriad Dec 8, 2018

Contributor
Suggested change Beta
"version": "3.1.5",
"version": "3.1.4",

The versions are actually changed automatically when we publish the packages. So we should keep it as is and only update the change log for now

@pbrocks

pbrocks approved these changes Dec 9, 2018

Copy link

pbrocks left a comment

Testing as-is the Metabox did not save using the Visual tab.
gutenberg-not-saving

When I added the window.tinyMCE.triggerSave(); snippet it did save.
gutenberg-metabox-saving

@youknowriad youknowriad added this to the 4.7 milestone Dec 9, 2018

@pbrocks

This comment has been minimized.

Copy link

pbrocks commented Dec 9, 2018

This comment confirms that the capitalization of the tinyMCE made a difference. In this screencast I tested lowercase first.
case-sensitive-tinymce

@youknowriad youknowriad merged commit 4ea5094 into WordPress:master Dec 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

pinarol added a commit that referenced this pull request Dec 11, 2018

Merge master into mobile (#12796)
* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

Tug added a commit that referenced this pull request Dec 13, 2018

Merge 'origin/master' into 'origin/mobile' (#12836)
* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

youknowriad added a commit that referenced this pull request Dec 19, 2018

Get the last mobile changes back in master (#12582)
* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText

Tug added a commit that referenced this pull request Dec 19, 2018

Merge master into mobile (#12796)
* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

Tug added a commit that referenced this pull request Dec 19, 2018

Merge 'origin/master' into 'origin/mobile' (#12836)
* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

grey-rsi pushed a commit to OnTheGoSystems/gutenberg that referenced this pull request Jan 4, 2019

When a post is saved, check for tinymce and save any editors. (WordPr…
…ess#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

@staurand staurand referenced this pull request Jan 4, 2019

Open

#1156 fixed in core #1211

youknowriad added a commit that referenced this pull request Jan 9, 2019

Get the last mobile changes back in master (#12582)
* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText

youknowriad added a commit that referenced this pull request Jan 9, 2019

Synchronize 4.8 with g-minor to include 4.8 into WordPress Core (#13261)
* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Add a line to PR template for developer documentation (#12822)

* Add a line to PR template for developer documentation

Developer documentation is critical for making a platform extendable,
developers need to know the proper way to extend a feature, or in a
sense that does may not even exist.

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Grammatical mistakes & Missing spaces (#12643)

* Grammatical mistakes & Missing spaces

Fixing grammatical mistakes & adding the required space between 2 lines.

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: faisal-alvi <faisalalvi33@gmail.com>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: faisal-alvi <faisalalvi33@gmail.com>

* Some content format issues (#12636)

I've noticed some content formatting issues while going through this page. Hence, I'm approaching some suggestion from my side.

* Fix incorrect value for __back_compat_meta_box (#12776)

* Fix Typo (#12902)

* fix typo (#12905)

* Fix Typo (#12918)

* fixed typo (#12936)

Changed from 'moreso than' to 'more so than'.

## Description
<!-- Please describe what you have changed or added -->

## How has this been tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, tests ran to see how -->
<!-- your change affects other areas of the code, etc. -->

## Screenshots <!-- if applicable -->

## Types of changes
<!-- What types of changes does your code introduce?  -->
<!-- Bug fix (non-breaking change which fixes an issue) -->
<!-- New feature (non-breaking change which adds functionality) -->
<!-- Breaking change (fix or feature that would cause existing functionality to not work as expected) -->

## Checklist:
- [ ] My code is tested.
- [ ] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [ ] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [ ] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->
- [ ] I've included developer documentation if appropriate. <!-- Handbook: https://wordpress.org/gutenberg/handbook/designers-developers/ -->

* Fix typo (#12937)

Fixed typo from 'comma separated' to 'comma-separated'.

* Add content to Contributors index page (#12910)

* Add content to Contributors index page

When visiting the Gutenberg Handbook the Contributors index page is
blank. See: https://wordpress.org/gutenberg/handbook/contributors/

This PR adds some basic content and links to find more, including
linking back to the repo's contributing document.

* Remove newlines, update links

* Getting Started with JavaScript (#12689)

* Getting Started with JavaScript

* Reorder add_action/function

* Update prefix to use myguten, instead of just my

* Update docs/designers-developers/developers/tutorials/javascript/readme.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update to block_editor_assets

* Updates per danielbachhuber review.

* Updates, and broken up into sections

* Add Troubleshooting

* Updates with suggestion. Props to @nosolosw

* Update docs/designers-developers/developers/tutorials/javascript/versions-and-building.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update docs/designers-developers/developers/tutorials/javascript/versions-and-building.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add screenshot with style

* Reorder TOC, move versions to end

* Update link for browser support

* Add check for dependency to troubleshooting section

* General edits for spelling and flow

* Update Table of Contents and generated manifest

* Fix up header tags consistency and spaces

* Edits per @chrisvanpatten review

* Update docs/designers-developers/developers/tutorials/javascript/extending-the-block-editor.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update docs/designers-developers/developers/tutorials/javascript/loading-javascript.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update docs/designers-developers/developers/tutorials/javascript/loading-javascript.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update docs/designers-developers/developers/tutorials/javascript/loading-javascript.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update docs/designers-developers/developers/tutorials/javascript/plugins-background.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update docs/designers-developers/developers/tutorials/javascript/plugins-background.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Move screenshots to assets directory, add additional screenshot for success

* Move block style variant to assets

* Formating

* Update images to full URLs

* Fix titles

* Fixed incorrect example code (#12906)

*  Build tooling: Fix Travis failures with Docker instances (#12983)

* Build tooling: Fix Travis failures with Docker instances

* Docs: Fix manifest file

* chore: Fix typo

* Add section to setAttributes documentation about immutability of attributes (#12811)

* Add section to setAttributes documentation about immutability of attributes

* Simplify explanation of immutable attributes

* Fix typo and add link to redux's immutability docs

Co-Authored-By: talldan <daniel.richards@automattic.com>

* Update recommended config provided for lint-js script (#12845)

* Update default config provided for lint-js script

* Update packages/scripts/CHANGELOG.md

* Clarify usage of recommended configs in docs

* Add JSHint ESLint config (#12840)

* Add ESLint JSHint config

* Update packages/eslint-plugin/README.md

Co-Authored-By: ntwb <stephen@netweb.com.au>

* Scripts: Add test-e2e script to wp-scripts (#12437)

* Scripts: Add test-e2e script

* Docs: Add docs for test-e2e script added to scripts packages

* Update package-lock.json

* Refactor scripts based on feedback shared in the review

* More fixes to wp-scripts test-e2e

* Address feedback shared in the review

* Fix runInBand flag usage

* [Documentation] fix link to edit-post documentation (#12835)

* fix link to edit-post documentation

* Update README.md

* Update README.md

* Get the last mobile changes back in master (#12582)

* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText

* Fix typo in docs/designers-developers/key-concepts.md (#13005)

* Scripts: Add lint-style script based on stylelint (#12722)

* Scripts: Add lint-css script based on stylelint

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update default config for lint-style script

* Scripts: Extend description for the package

* Expose unregisterBlockType for mobile (#13015)

* Tests: Enabled popular plugins on Travis when running e2e test suite (#12578)

* Tests: Enabled popular plugins on Travis when running e2e test suite

* Try running WP-CLI with a different user

* Tweak if statement

* Add back chmod dance on plugins related folders

* Create upgrade folder

* Add a temporary noop catch when api fetch for meta box save fails. Not having a catch caused an end to end test to fail.

* Fix: clickBelow logic clicked on the meta boxes when a big meta box was open.

* Make todo LOUD ;-)

* Remove obsolete lines after rebasing with master

* Let's try without AFC

* Trying without Yoast SEO this time

* Revert changes for the test

* Enable 2 more plugins

* Try without AMP

* Merge similar strings. (#12540)

* Remove temporary workaround that should have been removed in Gutenberg 4.5 (#12556)

* Remove duplicate toolbarcontainer class name (#12357)

* Remove duplicate toolbarcontainer class name

`components-toolbar` is added by `ToolbarContainer` itself, so we don’t need to add it again

* Swap components-toolbar between container and toolbar

* Disable clipboard button in file block during upload (#12499)

See #12493.

* Persist alignment when transforming a gallery to an image and vice-versa (#12242)

* Persist alignment when transforming a gallery to an image and vice-versa.

For #11374

* Optimize loop itteration for #12242

* temporarily disable link formatting (#13036)

* Docs: Release: Clarify pinging core team members (#12970)

* Docs: Release: Clarify pinging core team members

Reduce the bus factor by not referencing an individual contributor.

* docs: Add link to Gutenberg Core Team

* docs: Include direct links to Slack channel

* Add my name to CONTRIBUTORS.md file. (#13032)

* Small typo in the Range Control's readme (#12989)

Just a small typo in the documentation

* Update block design guidelines to include info on setup states (#12985)

* Update block design guidelines to include info on setup states

Proposed guidelines for when to include a setup state in your block design. Would appreciate feedback on content and validation of markdown syntax.

* Edited block-design.md to reflect comments on #12985

Made edits in response to comments from @jasmussen and @chrisvanpatten one #12985:

- Removed extra new lines around images
- Updated wording to resolve any confusion around setup state vs placeholder nomenclature.

* Tests: Disable a fragile link e2e test until it is improved (#13043)

* Docs: Remove shortname from fontsizes (#13033)

We are no longer using the `shortname` for `fontsizes`

* Improve documentation in CONTRIBUTING.md file (#11657)

* Improve: Docs in CONTRIBUTING.md file

Improve documentation in CONTRIBUTING.md file. Title-cased the headings and fixed grammatical/typo issues and errors.

* Applied comments from feedback

#11657 (comment)

* Docs: Update all local links in README files to work with npm (#13030)

* Docs: Update all local links in README files to work with npm

* Update packages/blocks/README.md

* Fix new lines in blocks README file

* Revert nux component link

* Revert link to the block library

* Update link to component from edit-post package

* Make help text more in line with other help texts (#11068)

* Make help text more in line with other help texts.

* Remove submodule.

* Update embed-preview.js

* Added MenuItem readme (#12485)

* Added MenuItem readme

* Updated spacing

Updated the spacing to remove unneccesary lines.

* Updated usage

Updated details for how and when to use the MenuItem component.

* Updated formatting errors

I believe I updated formatting errors in spacing, extra spaces as well as backticks.

* Fix up a few things!

- Ticks
- Restored an older version as there was a slight mixup
- Whitespace
- Other polish

* Radio documentation: updating radio readme (#11226)

* Updating Radio readme

Initial commit to update Radio readme. These changes add design documentation.

* Adding readme images

* Image path update

Updating the path of the images. Making a small tweak to phrasing.

* Updates so that only a single h1 is present

* image alt text removal

The alt text for these images has been removed because removing the images from the document doesn't affect comprehension.

* Removing images

* Removing images

* Removing images

* Adding images hosted on wordpress.org

* docs: tweak some usage recommendations

* Tweak spacing

* docs: Use headers

* Add: End 2 End tests on the sidebar premalinkl for CPT's. (#13060)

* Try: Improve scrolling of navigation menu on small screens (#12644)

* Try: Improve scrolling of navigation menu on small screens

We scroll the editing canvas, the inspector sidebar, and the block library independently at desktop breakpoints. We do this so that the sidebar inspector can stay in view even if you have scrolled far down the editing canvas, and to avoid scroll bleed.

However because the navigation sidebar (on the left) has flyout menus on the desktop breakpoints, we can't yet scroll this one separately. If a user has a bunch of plugins installed that add menu items, or a small screen, these manu items might go beyond the visible height of the viewport. To make these accessible regardless, when this happens the `body` element scrolls to let you reach them.

In this situation, there is currently an issue where the editing canvas might scroll out of view when you scroll to the bottom of the sidebar.

This PR improves that situation by making the editing canvas `position: fixed;`, same as the sidebar is. This ensures that the entire editor scrolls with you down the page, as you scroll the `body` content.

This needs a good testing. `position: fixed;` does not inherit from a relative parent, which means we have to specifiy a matrix of left margins to accommodate for the different configurations of the navigation menu: auto-collapsed, manually collapsed, or the default width. To test, please verify that everything works as intended. Please test:

- All breakpoints beyond the 600px small breakpoint.
- Fullscreen and not fullscreen modes.
- With the navigation menu auto collapsing, and explicitly collapsed.
- With the inspector sidebar present or hidden.
- With metaboxes present and not present.

* Add flex rule to fix IE issue.

* Address feedback, and fix test issue.

* Try making the test more reliable using small columns

* Avoid PHP notices in e2e tests plugins (#13094)

* Add an e2e test for blocks with meta attributes (#13095)

* Add end 2 end test to category addition (#13102)

This commit adds end 2 end tests to the category addition. Taxonomies are an area of the editor where we had some regressions in the past.
This is just a start, more tests will be added to test complex interactions using custom taxonomies.

* Update reference to design resources. (#13119)

Current link 404s; updating to point to the proper spot.

* Bump plugin version to 4.8

youknowriad added a commit that referenced this pull request Jan 9, 2019

Get the last mobile changes back in master (#12582)
* Make a simple version of DefaultBlockAppender for mobile (#12434)

* Make a simple version of DefaultBlockAppender for mobile

* Use the same padding used for other blocks in DefaultBlockAppender

* Update copy, auto focus and bind keypress

* Do not bind key events

* Change style of placeholder

* Stop using classname-to-style autotransform in react native (#12552)

* [RNMobile] Fix crash editing More blocks (#12620)

* Use onChange instead of onChangeText in PlainText updates.

* Convert the More block to Component, and re-use the same logic of the web when the field is empty.

* Remove unsed variable, and format code

* Move `);` to a new line

* Fix SVG styles for mobile (#12608)

* Fix SVG styles for mobile

* Simplify condition since className is always a string

* Check if Enter.key is the last inserted character, and add a new default block after the current More block. (#12639)

Note: This is detected after the fact, and the newline could be visible on the block for a very small time. This is OK for the alpha, we will revisit the logic later.
See wordpress-mobile/gutenberg-mobile#324

* Call blur when deselecting RichText or PlainText component. (#12765)

This is required to hide the keyboard when the focus moves to a non textual block.

* Merge master into mobile (#12796)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Update native more block styling (#12767)

* Update styling of more block

* Fix CI test

* Update spaces

* Convert indentation to tabs

* Fix lint issues

* Remove key attribute

* Set fixed width to the text input

* Make sure to properly compare empty text and undefined text variable before resetting the eventCount field. (#12815)

* Use the default "Read More" text on init only, giving the ability to user to empty the field and re-start with empty text (#12821)

* Merge 'origin/master' into 'origin/mobile' (#12836)

* RichText: fix onSetup doc (#12607)

* Update broken links (#12660)

* Update broken links

There was 2 broken links. I changed same way with Data Module Reference page.

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Update docs/designers-developers/developers/block-api/README.md

Co-Authored-By: cagdasdag <cagdasdag81@gmail.com>

* Docs: Update Glossary (#12479)

* Update glossar with missing terms

* Convert glossary to use dl/dt/dd dtags. Fixes #9976

* Fix TinyMCE link

* remove spacing around tags

* Add template definition, with link

* Updates per review

* Update docs/designers-developers/glossary.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()` (#12570)

* Add documentation for `safeDecodeURI()` and `filterURLForDisplay()`

* Whitespace

* Consistant Capit… i mean capitalization

* Oxford comma

Co-Authored-By: georgeh <george@hotelling.net>

* Update theme-support.md (#12661)

* Fix: Undoing Image Selection in Image Block results in Broken Image (#12567)

* Optimize isViewportMatch (#12542)

* Cache createBlock call in isUnmodifiedDefaultBlock (#12521)

* Cache createBlock call in isUnmodifiedDefaultBlock

* Invalidate cache when default block name changes

* Merge ifs

* Font Size Picker: Use a menuitemradio role and better labels. (#12372)

* Use a menuitemradio role and better labels.

* Restore Button and remove MenuItem import.

* Use template literals.

* Set document title for preview interstitial (#12466)

* Fix e2e tests after the WordPress 5.0 upgrade (#12715)

* Fix e2e tests after the WordPress 5.0 upgrade

* Remove the php unit tests testing the WP5.0 core instead of the plugin

* Meta Boxes: Don't hide disabled meta boxes by modifying DOM (#12628)

Hiding disabled meta boxes by setting `element.style.display = 'none'`
interferes with plugins like ACF which rely on being able to show and
hide meta boxes using `$.hide()` and `$.show()`.

Hiding the meta box using a new `.edit-post-meta-boxes-area .is-hidden`
class ensures that we don't interfere with third party code.

* Add a word-wrap style to the facebook embed preview screen  (#11890)

* Add a word-break style to the facebook embed preview screen to prevent the long embed url from breaking the block boundary

* Fix typo and missing space in scss comment

* Adding @aldavigdis to the contributors list (#12686)

* Make media & text block placeholder translatable (#12706)

* Fix: Problems on Media & Text block resizing; Load wp-block-library styles before wp-edit-blocks. (#12619)

* Get wordcount type from translation (#12586)

* get wordcount type from translation

* Add description to explain the options for wordcount type

* Added mylsef into contributors.md. :)

* Only render InserterWithShortcuts on hover (#12510)

* Fix issue where default appender has icons overlaying the text (#12536)

* Fix issue where default appender has icons overlaying the text

This fixes #11425.

It adds padding to the right of the default block appender to fit 3 icons.

* chore: Tweak spelling

* Classic Block: set correct focus back after blur (#12415)

* Classic Block: set correct focus back after blur

* Add e2e test

* reset bookmark on mousedown and touchstart

* e2e: Look for aria-label="Add Media" rather than "Insert Media"

* RichText: only replace range and nodes if different (#12547)

* RichText: only set range if different

* Check rangeCount

* Also compare nodes

* Add e2e test

* Simplify

* RichText: Document isRangeEqual

* Testing: RichText: Assure subscriber removal

* Unsubscribe in page.evaluate

* Mark temporary eslint-config package as private (#12734)

* When a post is saved, check for tinymce and save any editors. (#12568)

* When a post is saved, check for tinymce and save any editors.

* Importing tinymce and using tinyMCE vs the object stored in window.tinymce.

* Updated version number and changelog.

* no longer importing tinymce since we use the tinyMCE global. tinyMCE.triggerSave works now. checking if tinyMCE exists before making the call just in case.

* Using typeof to check for tinyMCE and fixed issues brought up in travis run.

* using window.tinyMCE again to avoid warning RE undefined var

* Restore the package.json version.

* Add e2e tests for the custom wp_editor metaboxes

* Rename functions, removing gutenberg_ prefix (#12326)

* Rename functions, removing gutenberg_ and prefixing with wp_

* Remove wp_ prefix to match core

* Remove function check per review

* Annotations: Apply annotation className as string (#12741)

* RichText: Ensure instance is selected before setting back selection (#12737)

* Fix for #11663 (#12728)

* Fixed Deleting an HTML Anchor attribute leaves an empty HTML id attribute

* Fixed Deleting an HTML Anchor attribute leaves an empty

* Update plugin version to 4.7.0-rc.1 (#12752)

* Add an error state to the image block to allow upload errors to display (#10224)

* Try: JS Console warning for when in Quirks Mode (#12575)

* Try: JS Console warning for when in Quirks Mode

This PR detects whether the browser is in Quirks Mode. Quirks Mode is a rendering method used when the doctype definition is missing or incorrectly placed in the HTML source, causing the browser to have difficulty detecting the type of document it is to render.

This is usually caused by a PHP error, or even just a style tag that is output incorrectly on the page. See discussion in #12455 and #11378.

The usual result is Gutenberg rendering incorrectly, notably with metaboxes overlapping content.

The purpose of this PR is to help developers debug the issue and fix it at the root. As such, it adds a console warning, props @nickcernis for the text:

```
[Warning] Your browser is using Quirks Mode. This can cause rendering issues such as blocks overlaying meta boxes in the editor. Quirks Mode can be triggered by PHP errors or HTML code appearing before the opening <!DOCTYPE html>. Try checking the raw page source or your site's PHP error log and resolving errors there, removing any HTML before the doctype, or disabling plugins.
```

It also augments the documentation to add a note about this.

* Move warning to index.js

* Remove try/catch.

* Tweak: Remove redundant [warning] in warn call

* Organizing screenshot assets for the block tutorial inside the designers-developers directory in the repo (#12745)

* Rename backwards compatiblity to backward compatibility (#12751)

* Rename backwards compatiblity to backward compatibility

* Remove package-lock from commit

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Update CONTRIBUTING.md

Co-Authored-By: mkaz <marcus@mkaz.com>

* Whitespace in manifest

* Update node-sass to 4.11.0 to support Node.js 11 (#12541)

## Description
Fixes #12539 by updating node-sass to support Node.js 11.

## How has this been tested?
Running `npm install` on macOS 10.14 with Node.js 11.2 without problems.

## Types of changes
Minor dependency bump to support Node.js 11.

## Checklist:
- [x] My code is tested.
- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->
- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->
- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->

* Add attributes to ServerSideRender readme (#12793)

* Add attributes to ServerSideRender readme

Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component.

* Add whitespace and inline code markup to ServerSideRender readme

Implements requested changes from code review.

* Scripts: Add check-engines script to the package (#12721)

* Scripts: Add check-engines script to the package

* Update packages/scripts/CHANGELOG.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update packages/scripts/README.md

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Update minimal node version to 10.x

Co-Authored-By: gziolo <grzegorz@gziolo.pl>

* Move devDependencies to root package.json file (#12720)

* Chore: Remove unused npm dependencies from the root package.json file

* Move devDependencies to root package.json file

* Fix php notice from the recent comments block (#12812)

* RichText: Fix React warning shown when unmounting a currently selected RichText. (#12817)

* Packages: Reimplement ESLint config as plugin (#12763)

* Packages: Move eslint-config to eslint-plugin

(Fails pre-commit, but in effort to ensure history preservation)

* eslint-plugin: Add npmrc to avoid package-lock.json

* Framework: Update path references for eslint-config to -plugin

* eslint-plugin: Reimplement ESLint config as plugin

* eslint-plugin: Unmark as private

* eslint-plugin: Undocument custom ruleset

* 4.7 (#12819)

* Bump plugin version to 4.7.0

* chore(release): publish

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

* Update changelogs after 4.7 package releases

* Add back package-lock.json

* Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)

* [rnmobile]: Send blockType prop to RNAztecView (#12869)

* Revert "Remove the call that does `blur` the undelying native component (#12946)

* Revert "Remove the call that does `blur` the undelying native component when deselecting RichText or PlainText. (#12886)"

This reverts commit d9fe45e.

* Blur only if it is iOS

* Fix imports

* Fix lint errors in the mobile branch (#12990)

* Revert changes to lib/load.php

* Fix lint errors in More

* Fix lint error for PlainText

* Fix lint error in RichText
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment