New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for latest posts time class #12725

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
5 participants
@kadencethemes
Copy link
Contributor

kadencethemes commented Dec 9, 2018

Description

Removed dynamic className from the time element in the latest posts block.

Fixes #12700

How has this been tested?

Yes, manually tested.

Types of changes

Small bug fix on classname

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@Soean

This comment has been minimized.

Copy link
Member

Soean commented Dec 9, 2018

Related #4018

@earnjam

This comment has been minimized.

Copy link
Contributor

earnjam commented Dec 9, 2018

This is the same approach from #4018, which was closed in favor of a broader solution for returning class names on the block render callback, but I think it would be best just to ship this in the interim until we get around to that. It's displaying fine on the front-end because it's hard-coded in PHP, but it's still broken in the editor and there hasn't been any progress since February.

@earnjam earnjam added this to the 4.8 milestone Dec 9, 2018

@aduth

aduth approved these changes Dec 11, 2018

@youknowriad youknowriad merged commit 445a0b2 into WordPress:master Dec 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Dec 20, 2018

Congrats for your first PR @kadencethemes

youknowriad added a commit that referenced this pull request Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment