Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Components: Render DropZone children only if dragging over element #12852
This pull request seeks to optimize the rendering of the DropZone component to omit its own children in lieu of rendering them styled as
Further, it refactors the rendering to avoid rendering its static set of children as an array. This may have some negligible improvement in React's reconciliation, though it has not been measured.
Verify there are no regressions in the behavior of drag-n-drop media (default block appender, before/after block, on media placeholder).
Compare DOM nodes between this branch and master:
referenced this pull request
Dec 13, 2018
Have tested a couple of scenarios:
Other than fixing some test snapshots, this works great and is ready for landing.