Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Components: Handle multiple Slots by same name #12882
This pull request seeks to resolve an issue where multiple Slot instances using the same name can conflict:
Repeat Steps to Reproduce from #12355, verifying that no duplicate toolbar is shown.
Verify there are no regressions in the behavior of Slot / Fill, both for
Ensure unit tests pass:
referenced this pull request
Dec 14, 2018
johngodley left a comment
I've been unable to reproduce the original problem on master. I guess something changed that's affected the order in which block duplication happens, and the slot's aren't used in the same way.
If I try code from before this PR then the problem is reproducible, and this PR does fix it. I've tried to test other instances of Slot/Fill, and haven't seen any side-effects so far.
Regardless of whether the block duplication shortcut causes a problem in master I think the fix is still important. Nice