Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix/issue 12501 menu item aria label #12955
How has this been tested?
Types of changes
Removed aria-label on the menuItem component because it was redundant with the button text itself. Also update the tests and snapshots to match the new output.
Hi @timwright12 thank you for your contribution!
I tested these changes on Mac with voice over. I verified that for menu items with keyboard shortcuts like "Code Editor" and "Visual Editor" in the ellipsis menu, previously voice over just announced the text, now voice-over announces the keyboard shortcuts too.
Regarding the end 2 end tests unfortunately previously we had problems that block end 2 end execution, would it be possible to rebase this branch so the end 2 end tests cannot be executed?
referenced this pull request
Jan 2, 2019
Hi @timwright12 I investigate the tests problem and I think the root cause of the issue is that we have a test util that relies on this aria labels being present.