Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: Add button styles to notice actions without url. Allow custom classes on notice actions. #13116
This PR applies the following changes:
How has this been tested?
I executed the following code on the console:
Jan 2, 2019
Nice work! Here's a GIF_
I'm not sure how this is compared ot master, it's very likely a vast improvement. If it is, probably good to get it in. However there are a couple of little visual glitches that could use polish if you have time:
Yeah maybe don't "fix" 3:
The X should be in the top right corner for more than 1 line of text, so it's probably correct as it is.
But still worth fixing the CSS bleed in the button that's styled as a link. Or maybe not? I know @aduth has some ideas for either retiring or changing the "is-link" style.