Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Rnmobile/upload media file #13128
This is the supporting PR for upload image file from react native Gutenberg editor
How has this been tested?
This PR can be tested from WPAndroid PR
referenced this pull request
Dec 28, 2018
etoledom left a comment •
Hey @marecar3 ! Thank you for your great work!
I like the idea of leaving all the networking to the parents app, while we use Gutenberg to show the upload state to the user.
I tried a fast implementation on the iOS side of media upload to see if we could have any compatibility issue. Sadly I did found a complication that didn't let me finish it. I explained that on a code comment.
Apart of that it looks good! I also added a small clean up comment but I don't think that is a blocking thing.
One more comment: I was working on another PR (#13096) that modifies the