/gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to gutenberg mobile #13199

Merged
merged 15 commits into from Jan 24, 2019
+225 −0

Conversation

Reviewers

@pinarol pinarol

@hypest hypest

@etoledom etoledom

Assignees

@diegoreymendez diegoreymendez

Labels
Mobile App Compatibility [Component] Mobile [Status] In Progress
Projects
None yet
Milestone
  5.0 (Gutenberg)
6 participants
@diegoreymendez @pinarol @youknowriad @mzorz @koke @daniloercoli
@diegoreymendez
Copy link
Contributor

diegoreymendez commented Jan 4, 2019 •
edited

Description

Adds post-title component support for mobile.

How has this been tested?

This PR should be tested through either of these branches:

gutenberg-mobile: wordpress-mobile/gutenberg-mobile#450
WPiOS: wordpress-mobile/WordPress-iOS#10794

titleinreactnative

Types of changes

Adds a .native.js file with the mobile-specific implementation of post-title.

To do:

Fix the build, which is failing for some reason. This shouldn't hold the reviews back, though.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

mzorz and others added some commits Dec 20, 2018

@mzorz
temporarily disable link formatting
49bb394
@koke
Make sure RichText resigns focus when unmounted (#13048)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
96a73c5
@diegoreymendez
Implements a native version of post-title.
e2b08e1
@diegoreymendez
Merge branch 'master' into mobileissue/372-add-title-to-gutenberg-mobile
Loading status checks…
40b7c9c

@diegoreymendez diegoreymendez added [Status] In Progress [Component] Mobile Mobile App Compatibility labels Jan 4, 2019

@diegoreymendez diegoreymendez self-assigned this Jan 4, 2019

This was referenced Jan 10, 2019

Merged
Merged

@diegoreymendez diegoreymendez requested review from etoledom , pinarol and hypest Jan 10, 2019

@pinarol

pinarol reviewed Jan 15, 2019
View changes

Show resolved Hide resolved packages/editor/src/components/post-title/index.native.js Outdated
Show resolved Hide resolved packages/editor/src/components/post-title/index.native.js Outdated
Show resolved Hide resolved packages/editor/src/components/post-title/index.native.js
Show resolved Hide resolved packages/editor/src/components/post-title/index.native.js
@pinarol

pinarol reviewed Jan 17, 2019
View changes

packages/editor/src/components/post-title/index.native.js

return {
clearSelectedBlock,
};

This comment has been minimized.

Sign in to view
Copy link
@pinarol

pinarol Jan 17, 2019

Contributor

so this was the thing I was referring to by disptaching to store, just like this one we can also inject onUpdate to props and use editPost( { title } ) to update the post in the store, just like the web side here:

gutenberg/packages/editor/src/components/post-title/index.js

Line 180 in c2f1059

onUpdate( title ) {

Show resolved Hide resolved packages/editor/src/components/post-title/index.native.js
@pinarol

pinarol approved these changes Jan 17, 2019
View changes

Copy link
Contributor

pinarol left a comment

Thanks Diego for this! My tests passed all ok! 🎉
I think there's one last thing that needs to be addressed and I've added a comment about it but feel free to create an issue for it and handle that separately, at this time it is enough if we just don't forget about it.

@daniloercoli daniloercoli referenced this pull request Jan 21, 2019

Merged

Implements the editor title in RN for Gutenberg #9027

@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into … 
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Loading status checks…
b5e679b

@diegoreymendez diegoreymendez merged commit ab0acc3 into master Jan 24, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@diegoreymendez

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

diegoreymendez commented Jan 24, 2019

Merging, but I'll be going through these PRs tomorrow to list any pending work.

Thanks for the feedback everyone.

@diegoreymendez diegoreymendez deleted the rnmobile/372-add-title-to-gutenberg-mobile branch Jan 24, 2019

@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Feb 4, 2019

This was referenced Feb 4, 2019

Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment