New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scrolling in fullscreen mode, notably for Edge #13327

Merged
merged 1 commit into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@jasmussen
Copy link
Contributor

jasmussen commented Jan 15, 2019

In #12644, we changed the behavior of scrolling for the main content area slightly, to address issues with scrolling on small screens.

As part of that, there was one small issue that made it slightly harder to scroll this main content area, only when in fullscreen mode in Microsoft Edge. This PR fixes that.

Another side effect of that prior PR was that it unset some of the scrolling rules that prevented CSS bleed (when you scroll to the end of the Block Library and proceed to scroll the body content). This PR restores that.

Before:

before

After:

after

Also tested in IE:

ie11

Improve scrolling in fullscreen mode, notably for Edge
In #12644, we changed the behavior of scrolling for the main content area slightly, to address issues with scrolling on small screens.

As part of that, there was one small issue that made it slightly harder to scroll this main content area, only when in fullscreen mode in Microsoft Edge. This PR fixes that.

Another side effect of that prior PR was that it unset some of the scrolling rules that prevented CSS bleed (when you scroll to the end of the Block Library and proceed to scroll the body content). This PR restores that.

@jasmussen jasmussen added this to the 5.0 (Gutenberg) milestone Jan 15, 2019

@jasmussen jasmussen self-assigned this Jan 15, 2019

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Jan 15, 2019

@aduth

This comment has been minimized.

Copy link
Member

aduth commented Jan 16, 2019

The issue described at #12644 (comment) is not resolved after these changes. Should we address separately or is it fundamentally tied to the specific direction we've taken with this implementation?

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

jasmussen commented Jan 17, 2019

The issue described at #12644 (comment) is not resolved after these changes. Should we address separately or is it fundamentally tied to the specific direction we've taken with this implementation?

Can you clarify this a little bit? I just tried this and it's working for me, but I may be misunderstanding your comment?

click below

@aduth

This comment has been minimized.

Copy link
Member

aduth commented Jan 18, 2019

Ah! I thought I'd tested on this branch. It's broken on master, but appears fixed here. A nice two-for-one then 😄

@aduth

aduth approved these changes Jan 18, 2019

Copy link
Member

aduth left a comment

👍

@youknowriad youknowriad merged commit 0c1f125 into master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/edge-fullscreen-scroll branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment