New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissible-notices: fix text overlapping icon (X) #13371

Merged
merged 3 commits into from Jan 23, 2019

Conversation

Projects
None yet
4 participants
@Naerriel
Copy link
Contributor

Naerriel commented Jan 19, 2019

Description

Fix of issue #11156 - added a margin on the right of dismissible notices.

How has this been tested?

I looked on the styles manually on left-to-right and right-to-left views.

Screenshots

dismissible-notice

Types of changes

Change in styles.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

Thank you for your changes @Naerriel, things worked great on my tests and it improves the behavior in some resolutions and when resizing.
Before:
jan-21-2019 10-39-48

After:
jan-21-2019 10-38-42

@jorgefilipecosta

This comment has been minimized.

Copy link
Member

jorgefilipecosta commented Jan 21, 2019

Pinging to @jasmussen to have a last look regarding the design/CSS change.

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Jan 21, 2019

Love it. Can we change the 25px to #{ $icon-button-size-small + $border-width }? That comes to the same, but uses variables.

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Jan 22, 2019

@Naerriel would you mind applying the change @jasmussen shared so we could merge your first contribution? :)

@Naerriel

This comment has been minimized.

Copy link
Contributor Author

Naerriel commented Jan 22, 2019

@jasmussen @gziolo Thank you for feedback and reminding me. :)

@gziolo

gziolo approved these changes Jan 23, 2019

Copy link
Member

gziolo left a comment

All good, nice work 👍

Congrats on your first contribution landing to Gutenberg 🎉

@gziolo gziolo merged commit e1d2e66 into WordPress:master Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

daniloercoli added a commit that referenced this pull request Jan 24, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment