New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the inserter search result message from assertive to polite #13388

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@afercia
Copy link
Contributor

afercia commented Jan 20, 2019

This PR seeks to improve screen readers behavior when using the Inserter. For more details please refer to the related issue #13387.

Please first test on current master:

  • use Safari + VoiceOver
  • tab to the main inserter button
  • press Control Option Spacebar
  • the inserter opens, focus is moved to the search field
  • the search field label "Search for a block" is not announced
  • the number of results is announced almost immediately

Switch to this branch

  • repeats the steps above
  • check the search field label "Search for a block" is announced correctly, followed by the number of results

screenshot 2019-01-20 at 18 44 50

Fixes #13387

@afercia afercia force-pushed the update/inserter-search-result-message-polite branch from f5e8b07 to fa62d12 Jan 21, 2019

@afercia

This comment has been minimized.

Copy link
Contributor Author

afercia commented Jan 21, 2019

Rebased to incorporate the changes from #13395 and pass the tests.

@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

I'm not sure of the reason why a message using 'assertive' option disappears faster, but I followed the test steps, and I verified that before the message disappeared almost immediately on voice over without being totally spoken and now the message is completely spoken.

@afercia

This comment has been minimized.

Copy link
Contributor Author

afercia commented Jan 25, 2019

Thanks @jorgefilipecosta. To clarify: it's the assertive message "61 results found" that was interrupting the screen reader while it was reading the search field label, so "Search for a block" wasn't announced.

With this change, the search field label is read out first, followed by the number of results.

@afercia afercia merged commit f1e8271 into master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@afercia afercia deleted the update/inserter-search-result-message-polite branch Jan 25, 2019

@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment