Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upeslint-plugin: Enforce object-shorthand #13400
Conversation
aduth
added some commits
Jan 21, 2019
aduth
added
the
[Package] ESLint plugin
label
Jan 21, 2019
gziolo
approved these changes
Jan 22, 2019
Love this change All changes look great. |
gziolo
added
the
[Type] Code Quality
label
Jan 22, 2019
gziolo
added this to the 5.0 (Gutenberg) milestone
Jan 22, 2019
aduth
added some commits
Jan 22, 2019
aduth
merged commit af9ea75
into
master
Jan 22, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
aduth
deleted the
add/eslint-config-object-shorthand
branch
Jan 22, 2019
This comment has been minimized.
This comment has been minimized.
Discussed in #core-js weekly meeting (link requires registration) https://wordpress.slack.com/archives/C5UNMSU4R/p1548167064197400 Per discussion, I updated the |
Feb 4, 2019
This was referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
aduth commentedJan 21, 2019
This pull request seeks to propose adding
object-shorthand
as an enforced rule in the ESLint default configurations. This shorthand is conventionally used in most places, though by the omission of the rule, some inconsistencies have surfaced. The rule provides a "fixable" implementation, used here to correct the inconsistencies.Pending Considerations:
This addition should be made in conjunction with a discussion in Core JS weekly chat about introduction of new rules, particularly with regard to:
Testing instructions:
There should be no lint errors: