New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the fullscreen "exit" icon with a back arrow #13403

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
3 participants
@kjellr
Copy link
Contributor

kjellr commented Jan 21, 2019

As per the notes in #10813, this PR updates the full screen "Exit" icon with a "Back" icon and label instead.

This icon is more common across the web, and will thus be a bit less confusing for users.

Note: The original issue suggested using a Material icon, but I've just swapped this out with the equivalent Dashicon for simplicity in implementtion. If someone knows how to swap that out with a SVG, go for it. 馃憤

Replace the fullscreen "exit" icon with a back arrow
As per the notes in #10813, this PR updates the full screen "Exit" icon with a "Back" icon and label instead.

This icon is more common across the web, and will thus be a bit less confusing for users.

Note: The original issue suggested using a Material icon, but I've just swapped this out with the equivalent Dashicon for simplicity in implementtion. If someone knows how to swap that out with a SVG, go for it. 馃憤
@jasmussen
Copy link
Contributor

jasmussen left a comment

screenshot 2019-01-22 at 13 09 45

Nice.

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 25, 2019

@gziolo gziolo merged commit edc97d9 into master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the try/replace-fullscreen-icon-with-back-button branch Jan 25, 2019

daniloercoli added a commit that referenced this pull request Jan 26, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into 鈥
鈥nmobile/372-enter-key-detection-to-title

* 'master' of https://github.com/WordPress/gutenberg: (29 commits)
  Update for RangeControl documentation (#12564)
  Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456)
  Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488)
  Replace the fullscreen "exit" icon with a back arrow (#13403)
  Include :visited links in button color (#12183)
  Amazon Kindle block (#13510)
  Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457)
  Add watcher on Linux: change fs to node-watch (#13448)
  Plugin: Deprecate `gutenberg` theme support (#13458)
  Datepicker: Add inValidDay support (#12962)
  Block Switcher: Render disabled button even if multi-selection (#13431)
  Plugin: Deprecate gutenberg_register_post_types (#13468)
  Plugin: Deprecate register_tinymce_scripts (#13466)
  Set minimum of words for RSS excerpt (#13502)
  Plugin: Deprecate gutenberg_get_block_categories (#13454)
  Plugin: Deprecate gutenberg_content_block_version (#13469)
  API Fetch: Expose nonce on created middleware function (#13451)
  Plugin: Remove list screens integrations (#13459)
  Plugin: Remove core-defined block detection functions (#13467)
  Spec Parser: Move generated spec parser to package (#13493)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment