Replace the fullscreen "exit" icon with a back arrow #13403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the notes in #10813, this PR updates the full screen "Exit" icon with a "Back" icon and label instead. This icon is more common across the web, and will thus be a bit less confusing for users. Note: The original issue suggested using a Material icon, but I've just swapped this out with the equivalent Dashicon for simplicity in implementtion. If someone knows how to swap that out with a SVG, go for it. 👍
kjellr
added
[Type] Enhancement
daniloercoli
added a commit
that referenced
this pull request
Jan 26, 2019
…rnmobile/372-enter-key-detection-to-title * 'master' of https://github.com/WordPress/gutenberg: (29 commits) Update for RangeControl documentation (#12564) Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456) Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488) Replace the fullscreen "exit" icon with a back arrow (#13403) Include :visited links in button color (#12183) Amazon Kindle block (#13510) Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457) Add watcher on Linux: change fs to node-watch (#13448) Plugin: Deprecate `gutenberg` theme support (#13458) Datepicker: Add inValidDay support (#12962) Block Switcher: Render disabled button even if multi-selection (#13431) Plugin: Deprecate gutenberg_register_post_types (#13468) Plugin: Deprecate register_tinymce_scripts (#13466) Set minimum of words for RSS excerpt (#13502) Plugin: Deprecate gutenberg_get_block_categories (#13454) Plugin: Deprecate gutenberg_content_block_version (#13469) API Fetch: Expose nonce on created middleware function (#13451) Plugin: Remove list screens integrations (#13459) Plugin: Remove core-defined block detection functions (#13467) Spec Parser: Move generated spec parser to package (#13493) ...
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
As per the notes in #10813, this PR updates the full screen "Exit" icon with a "Back" icon and label instead. This icon is more common across the web, and will thus be a bit less confusing for users. Note: The original issue suggested using a Material icon, but I've just swapped this out with the equivalent Dashicon for simplicity in implementtion. If someone knows how to swap that out with a SVG, go for it. 👍
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
As per the notes in #10813, this PR updates the full screen "Exit" icon with a "Back" icon and label instead. This icon is more common across the web, and will thus be a bit less confusing for users. Note: The original issue suggested using a Material icon, but I've just swapped this out with the equivalent Dashicon for simplicity in implementtion. If someone knows how to swap that out with a SVG, go for it. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the notes in #10813, this PR updates the full screen "Exit" icon with a "Back" icon and label instead.
This icon is more common across the web, and will thus be a bit less confusing for users.
Note: The original issue suggested using a Material icon, but I've just swapped this out with the equivalent Dashicon for simplicity in implementtion. If someone knows how to swap that out with a SVG, go for it. 👍