New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix Notices documentation data handbook reference #13409

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@aduth
Copy link
Member

aduth commented Jan 21, 2019

Related: #11604 (comment)

This pull request seeks to resolve a broken link in the Notices module documentation.

Broken: https://wordpress.org/gutenberg/handbook/packages/packages-data/packages-data-core-edit-post/
Fixed: https://wordpress.org/gutenberg/handbook/designers-developers/developers/data/data-core-notices/

Testing instructions:

Verify from the preview that the "Notices Data Handbook page" link navigates to a non-404 page.

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Jan 22, 2019

14f175f - I updated the link to reference GitHub directly. Starting the url with the top folder allows us to do that. This will also work on npm and for Gutenberg handbook, it is going to be properly updated by set of regular expression applied behind the scenes :)

Saying that, I'm coming to the conclusion that I need to document all those guidelines which emerged when dealing with links.

@gziolo

gziolo approved these changes Jan 22, 2019

Copy link
Member

gziolo left a comment

🚢

@gziolo gziolo added this to the Documentation & Handbook milestone Jan 22, 2019

@gziolo gziolo merged commit 0bf39b4 into master Jan 22, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gziolo gziolo deleted the fix/docs-notices-handbook-selectors branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment