Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDocs: Fix Notices documentation data handbook reference #13409
Conversation
aduth
added
[Type] Documentation
[Package] Notices
labels
Jan 21, 2019
aduth
referenced this pull request
Jan 21, 2019
Merged
Compat: Upgrade admin notices to use Notices module at runtime #11604
This comment has been minimized.
This comment has been minimized.
|
14f175f - I updated the link to reference GitHub directly. Starting the url with the top folder allows us to do that. This will also work on npm and for Gutenberg handbook, it is going to be properly updated by set of regular expression applied behind the scenes :) Saying that, I'm coming to the conclusion that I need to document all those guidelines which emerged when dealing with links. |
gziolo
added this to the Documentation & Handbook milestone
Jan 22, 2019
gziolo
merged commit 0bf39b4
into
master
Jan 22, 2019
1 check was pending
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
gziolo
deleted the
fix/docs-notices-handbook-selectors
branch
Jan 22, 2019
This was referenced Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
aduth commentedJan 21, 2019
Related: #11604 (comment)
This pull request seeks to resolve a broken link in the Notices module documentation.
Broken: https://wordpress.org/gutenberg/handbook/packages/packages-data/packages-data-core-edit-post/
Fixed: https://wordpress.org/gutenberg/handbook/designers-developers/developers/data/data-core-notices/
Testing instructions:
Verify from the preview that the "Notices Data Handbook page" link navigates to a non-404 page.