New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making Fullscreen Mode effects visible only on larger screens #13425

Merged
merged 3 commits into from Jan 23, 2019

Conversation

Projects
None yet
3 participants
@kjellr
Copy link
Contributor

kjellr commented Jan 22, 2019

Currently, if you activate Fullscreen Mode while on a desktop screen, the editor takes up the full screen: the admin bar is hidden, and we show a close icon on the top left of your screen. This behavior persists on smaller screens:

Left: Fullscreen Mode inactive, Right: Fullscreen Mode active
frame

This is a little confusing, since the Fullscreen Mode toggle is not available on small screens. If you're on mobile and you have fullscreen mode active, there's no way to toggle it back off.

fullscreen-current

In light of this, we should consider having fullscreen mode only effect desktop screens. This PR moves fullscreen styles into the medium breakpoint to try that out:

fullscreen-edited

Note that this mimics the behavior of the other two editing modes (Top Toolbar and Spotlight Mode, which are only available on desktop screens).

kjellr added some commits Jan 22, 2019

Hide the fullscreen "exit" icon on small screens
When fullscreen mode is active, we place an exit/back button in the upper left corner of the screen to give users a way to exit the editor.

This button persists on small screens, even though Fullscreen Mode cannot be toggled at that screen size.

This commit hides the exit/back icon at small screen sizes.
#wpfooter {
margin-left: 0;
}
// Reset the html.wp-topbar padding

This comment has been minimized.

@jasmussen

jasmussen Jan 23, 2019

Contributor

In honor of @tofumatt, should we add a period at the end of this line?

This comment has been minimized.

@gziolo

gziolo Jan 23, 2019

Member

Done 0e38e62 :)

@jasmussen jasmussen self-requested a review Jan 23, 2019

@jasmussen
Copy link
Contributor

jasmussen left a comment

Left a tiny comment. I dig this a lot, it feels very consistent with the other desktop-specific offerings. 👍 👍

@jasmussen jasmussen added this to the 5.0 (Gutenberg) milestone Jan 23, 2019

@gziolo gziolo merged commit 2da2a2c into master Jan 23, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gziolo gziolo deleted the fix/hide-fullscreen-exit-button-on-small-screens branch Jan 23, 2019

daniloercoli added a commit that referenced this pull request Jan 24, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment