New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-shallow-equal: Use ES5 ruleset from eslint-plugin module #13428

merged 1 commit into from Jan 23, 2019


None yet
2 participants
Copy link

aduth commented Jan 22, 2019

Related: Discussion (link requires registration)

This pull request seeks to update the ESLint configuration for is-shallow-equal to extend the ES5 ruleset provided through @wordpress/eslint-plugin. The is-shallow-equal package is an exception to most in its omission from Babel build.

Testing instructions:

Verify there are no lint errors:

npm run lint-js

gziolo approved these changes Jan 23, 2019

Copy link

gziolo left a comment

Kinda awkward to override this way. Misses some rules we might want from the ancestry, and re-enabling those rules for subdirectories (test) is tedious.
Probably good idea to keep these exceptions to a minimum

I agree with your point being made on Slack.

Changes look good 👍

@aduth aduth merged commit 0259f7b into master Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@aduth aduth deleted the fix/es5-rules branch Jan 23, 2019

daniloercoli added a commit that referenced this pull request Jan 24, 2019

Merge branch 'master' of into …

* 'master' of (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)

@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment