New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Categories block: add custom classes only to wrapper #13439

Merged
merged 5 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@Soean
Copy link
Member

Soean commented Jan 23, 2019

Description

The custom classes should only be added to the wrapper element. Same as in #13432

@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

The changes make sense 👍

Show resolved Hide resolved packages/block-library/src/categories/edit.js Outdated
Show resolved Hide resolved packages/block-library/src/categories/edit.js Outdated

@Soean Soean added this to the 5.0 (Gutenberg) milestone Jan 24, 2019

@Soean Soean merged commit 9a35324 into master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Soean Soean deleted the fix/categories-classname branch Jan 24, 2019

daniloercoli added a commit that referenced this pull request Jan 24, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment