New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_preload_api_request #13453

Merged
merged 3 commits into from Jan 25, 2019

Conversation

Projects
2 participants
@aduth
Copy link
Member

aduth commented Jan 23, 2019

Related: #11015

This pull request seeks to deprecate Gutenberg's gutenberg_preload_api_request in favor of the equivalent core function rest_preload_api_request.

Testing instructions:

Verify there are no regressions in the loading of the Gutenberg editor, importantly with regards to preloaded data (for example, there should be no XHR request for the post data).

@aduth aduth added this to In Progress in Remove PHP Jan 23, 2019

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Jan 25, 2019

'/wp/v2/taxonomies?per_page=-1&context=edit',

Unrelated: This path might need to be updated in the preloaded urls, as we're paginating now.

@aduth aduth merged commit 5e85519 into master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 25, 2019

@aduth aduth deleted the remove/rest-api-preload branch Jan 25, 2019

@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment