/gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_add_responsive_body_class #13461

Merged
merged 1 commit into from Jan 24, 2019
+4 −5

Conversation

Reviewers

@danielbachhuber danielbachhuber

@notnownikki notnownikki

@jeremyfelt jeremyfelt

Assignees
No one assigned
Labels
Good First Review [Block] Embed [Component] Plugin
Projects
  
Done in Remove PHP
Milestone
  5.0 (Gutenberg)
4 participants
@aduth @danielbachhuber @notnownikki @youknowriad
@aduth
Copy link
Member

aduth commented Jan 24, 2019 •
edited

Related: #11015
Related: #10477

This pull request seeks to deprecate and remove logic from gutenberg_add_responsive_body_class . This is now handled automatically in core as of WordPress 5.0.

See:

Testing instructions:

Repeat testing instructions from #10477.

@aduth aduth added [Component] Plugin [Block] Embed Good First Review labels Jan 24, 2019

@aduth aduth added this to In Progress in Remove PHP via automation Jan 24, 2019

@aduth aduth requested review from jeremyfelt , notnownikki and danielbachhuber Jan 24, 2019

@danielbachhuber

danielbachhuber approved these changes Jan 24, 2019
View changes

@notnownikki

notnownikki approved these changes Jan 24, 2019
View changes

Copy link
Member

notnownikki left a comment

Works as expected. 🚢

@aduth aduth force-pushed the deprecate/gutenberg_add_responsive_body_class branch from 87534e2 to f7d6320 Jan 24, 2019

@aduth aduth merged commit ff9961b into master Jan 24, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 24, 2019

@aduth aduth deleted the deprecate/gutenberg_add_responsive_body_class branch Jan 24, 2019

@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Jan 24, 2019

daniloercoli added a commit that referenced this pull request Jan 24, 2019

@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into … 
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Loading status checks…
b5e679b

This was referenced Feb 4, 2019

Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment