New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_add_gutenberg_post_state #13471

Merged
merged 2 commits into from Jan 28, 2019

Conversation

Projects
2 participants
@aduth
Copy link
Member

aduth commented Jan 24, 2019

Related: #11015

This pull request seeks to deprecate and remove logic from gutenberg_add_gutenberg_post_state . This added the "Gutenberg" text on a post in the post listing screen.

image

With 5.0 being released, this no longer really serves a purpose to distinguish posts.

Testing instructions:

Verify there is no "Gutenberg" label on posts in the post listing screen.

@aduth aduth added this to In Progress in Remove PHP via automation Jan 24, 2019

@aduth aduth force-pushed the remove/gutenberg-post-state branch from 3b8f5e8 to 1556bf2 Jan 24, 2019

@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

LGTM 👍 The editor continues to work as before, the warning related to the containing Gutenberg blocks still appear if we try to open the post in the classic editor. I did not found any other usage of gutenberg_add_gutenberg_post_state.

@aduth

This comment has been minimized.

Copy link
Member Author

aduth commented Jan 28, 2019

the warning related to the containing Gutenberg blocks still appear if we try to open the post in the classic editor.

For what it's worth, this will separately be removed as of #13442 . Kinda curious how you were able to load the classic editor in the first place 🤔

@aduth aduth merged commit a5e069b into master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 28, 2019

@aduth aduth deleted the remove/gutenberg-post-state branch Jan 28, 2019

daniloercoli added a commit that referenced this pull request Jan 28, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-move-title-to-rich-text

* 'master' of https://github.com/WordPress/gutenberg:
  Adds undo/redo support for the title. (#13514)
  Fix typo (#13524)
  RichText: List: Fix indent/outdent (#12667)
  Fixes tense on verb “assign” to correct tense (#13541)
  Plugin: Deprecate metabox supports, fall back to core (#13449)
  Rnmobile/upload media file (#13128)
  Plugin: Remove redundant core compatibility from plugin (#13442)
  Testing: Remove PHPUnit tests covering core functions (#13513)
  Plugin: Deprecate gutenberg_add_gutenberg_post_state (#13471)

@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment