New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Deprecate gutenberg_remove_wpcom_markdown_support #13473

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@aduth
Copy link
Member

aduth commented Jan 24, 2019

Related: #11015

This pull request seeks to deprecate and remove logic from gutenberg_remove_wpcom_markdown_support . This was a specific plugin compatibility targeting Jetpack. The root issue was fixed in Jetpack as of v6.8.

See:

Testing instructions:

Repeat testing instructions from Automattic/jetpack#10635 .

cc @tyxla , @kraftbj, @jeherve

@aduth aduth added this to In Progress in Remove PHP via automation Jan 24, 2019

@aduth aduth requested a review from mkaz Jan 24, 2019

if ( class_exists( 'WPCom_Markdown' ) && has_blocks( $post['post_content'] ) ) {
WPCom_Markdown::get_instance()->unload_markdown_for_posts();
}
_deprecated_function( __FUNCTION__, '5.0.0' );

This comment has been minimized.

@youknowriad

youknowriad Jan 24, 2019

Contributor

Not sure what the version refers to here. Should it be the version where we remove it from Gutenberg? 5.1 or 5.2?

This comment has been minimized.

@aduth

aduth Jan 24, 2019

Author Member

Our use of _deprecated_function would probably be discouraged anyways, but as it's implemented, it's meant to serve to describe the version at which it became deprecated, not when it's to be removed.

$version
(string) (Required) The version of WordPress that deprecated the function.

https://developer.wordpress.org/reference/functions/_deprecated_function/

@aduth aduth merged commit 884cabf into master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 24, 2019

@aduth aduth deleted the remove/gutenberg_remove_wpcom_markdown_support branch Jan 24, 2019

@mkaz

This comment has been minimized.

Copy link
Member

mkaz commented Jan 24, 2019

👍 I'm late to the game but looks good. I tested it out on Gutenberg with latest Jetpack and no problems.

@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Jan 24, 2019

daniloercoli added a commit that referenced this pull request Jan 24, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-add-title-to-gutenberg-mobile

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Save package-lock.json file changes (#13481)
  Plugin: Deprecate gutenberg_add_responsive_body_class (#13461)
  Add speak messages to the feature toggle component. (#13385)
  Plugin: Deprecate gutenberg_kses_allowedtags (#13460)
  Plugin: Deprecate gutenberg_bulk_post_updated_messages (#13472)
  Plugin: Avoid calling deprecated gutenberg_silence_rest_errors (#13446)
  Plugin: Deprecate gutenberg_remove_wpcom_markdown_support (#13473)
  Fix: Categories block: add custom classes only to wrapper (#13439)
  is-shallow-equal: Use ES5 ruleset from eslint-plugin module (#13428)
  Update and Organize Contributors Guide per #12916 (#13352)
  Dismissible-notices: fix text overlapping icon (X) (#13371)
  Framework: Remove 5.0-merged REST API integrations (#13408)
  Plugin: Remove 5.0-merged block registration functions, integrations (#13412)
  Framework: Bump minimum required WP to 5.x (#13370)
  [Mobile] Improve keyboard hide button (#13415)
  Improve castError handling of non strings (#13315)
  Fix: File block add custom class (#13432)
  Consider making Fullscreen Mode effects visible only on larger screens (#13425)
  Update plugin version to 4.9.0 (#13436)
  DateTimePicker: fix prop warning for (#12933)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment