Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFile Block: Remove the "Show Download Button" toggle help text #13485
Conversation
kjellr
added
Accessibility
Blocks
Needs Design Feedback
[Block] File
labels
Jan 24, 2019
kjellr
self-assigned this
Jan 24, 2019
kjellr
requested a review
from WordPress/gutenberg-core
Jan 24, 2019
kjellr
referenced this pull request
Jan 24, 2019
Closed
File Block: Consider removing the toggle control help text under the "Show Download Button" toggle. #13429
gziolo
added
the
Good First Review
label
Jan 24, 2019
youknowriad
added this to the 5.0 (Gutenberg) milestone
Jan 25, 2019
gziolo
merged commit 2d7035b
into
master
Jan 25, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
gziolo
deleted the
update/remove-download-button-help-text
branch
Jan 25, 2019
This was referenced Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kjellr commentedJan 24, 2019
As per discussion in #13429, this help text is redundant and can be removed.
There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.
Before:
After:
