New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Block: Remove the "Show Download Button" toggle help text #13485

Merged
merged 1 commit into from Jan 25, 2019

Conversation

@kjellr
Copy link
Contributor

kjellr commented Jan 24, 2019

As per discussion in #13429, this help text is redundant and can be removed.

There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.

Before:
51555310-55a58b80-1e45-11e9-927e-de833e6c33be

After:
screen shot 2019-01-24 at 9 37 48 am

File Block: Remove the "Show Download Button" toggle help text
As per discussion in #13429, this help text is redundant and can be removed.

There's still some discussion to be had about adding some sort of "on/off" text to clarify the state for toggles like this, but that should be tackled globally.
@mapk

mapk approved these changes Jan 24, 2019

Copy link
Contributor

mapk left a comment

Tested and looks great. Ship it.

@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Jan 25, 2019

@gziolo gziolo merged commit 2d7035b into master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/remove-download-button-help-text branch Jan 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment