New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Use placeholder for minimum WordPress version notice #13487

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
2 participants
@aduth
Copy link
Member

aduth commented Jan 24, 2019

See: #13370 (comment)

This pull request seeks to update the string used in the minimum required version notice to use placeholders. This is done to avoid the string changing for translators between revisions to the minimum required version.

Testing instructions:

Downgrade to an earlier version of WordPress while Gutenberg is active, and verify there are no regressions in the display of the version notice when Gutenberg self-deactivates.

Show resolved Hide resolved gutenberg.php Outdated
Collapse echo sprintf to printf
Co-Authored-By: aduth <andrew@andrewduthie.com>

@aduth aduth merged commit a99bc7d into master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the update/version-notice-placeholder branch Jan 24, 2019

@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment