New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS block: excerpt length label #13501

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
4 participants
@Soean
Copy link
Member

Soean commented Jan 25, 2019

Description

Changes the label of max word length setting in the RSS block.

From Max length of the excerpt to Max number of words in excerpt

Before:
bildschirmfoto 2019-01-25 um 11 58 07

After:
bildschirmfoto 2019-01-25 um 12 00 54

Part of this issue collection: #13498

@gziolo gziolo referenced this pull request Jan 25, 2019

Open

Improve RSS Block #13498

2 of 5 tasks complete

@Soean Soean changed the title Change RSS excerpt length label RSS block: excerpt length label Jan 25, 2019

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 25, 2019

@gziolo

gziolo approved these changes Jan 25, 2019

Copy link
Member

gziolo left a comment

Code 👍

I hope we get also copy confirmation from someone who previously worked on PRs with copy updates:

@michelleweber, @samikeijonen or @dimadin?

We are also seeking for help with reviewing all translations added to the new RSS block.

@michelleweber

This comment has been minimized.

Copy link

michelleweber commented Jan 25, 2019

Looks good!

@gziolo gziolo merged commit 2b49f1e into master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/rss-word-length branch Jan 25, 2019

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Jan 25, 2019

Thanks, @michelleweber for very quick feedback, much appreciated 🙇

@samikeijonen

This comment has been minimized.

Copy link
Contributor

samikeijonen commented Jan 25, 2019

+1 from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment