New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Kindle block #13510

Merged
merged 5 commits into from Jan 25, 2019

Conversation

Projects
None yet
2 participants
@Soean
Copy link
Member

Soean commented Jan 25, 2019

Description

Adds an Amazon Kindle embed block.

Amazon Kindle embed support was added in WP 4.9 https://core.trac.wordpress.org/changeset/41615

Example URL: https://lesen.amazon.de/kp/embed?asin=B07HB5N1YN
How to get URLs: https://www.amazon.com/Kindle-Instant-Preview/b?ie=UTF8&node=13489836011

Fixes #13427

kindle

kindle

@Soean Soean requested a review from notnownikki Jan 25, 2019

@notnownikki
Copy link
Member

notnownikki left a comment

Just one request to change to the responsive setting to false, and this is looking good!

Soean added some commits Jan 25, 2019

@notnownikki notnownikki added this to the 5.0 (Gutenberg) milestone Jan 25, 2019

@notnownikki

This comment has been minimized.

Copy link
Member

notnownikki commented Jan 25, 2019

Thank you!

@notnownikki notnownikki merged commit a474438 into master Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@notnownikki notnownikki deleted the add/kindle-embed branch Jan 25, 2019

daniloercoli added a commit that referenced this pull request Jan 26, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-enter-key-detection-to-title

* 'master' of https://github.com/WordPress/gutenberg: (29 commits)
  Update for RangeControl documentation (#12564)
  Plugin: Deprecate gutenberg_load_list_reusable_blocks (#13456)
  Update the columns attribute in onSelectImages so that if images are removed via the media modal, the columns can't be higher than the new number of images (#13488)
  Replace the fullscreen "exit" icon with a back arrow (#13403)
  Include :visited links in button color (#12183)
  Amazon Kindle block (#13510)
  Plugin: Deprecate gutenberg_prepare_blocks_for_js (#13457)
  Add watcher on Linux: change fs to node-watch (#13448)
  Plugin: Deprecate `gutenberg` theme support (#13458)
  Datepicker: Add inValidDay support (#12962)
  Block Switcher: Render disabled button even if multi-selection (#13431)
  Plugin: Deprecate gutenberg_register_post_types (#13468)
  Plugin: Deprecate register_tinymce_scripts (#13466)
  Set minimum of words for RSS excerpt (#13502)
  Plugin: Deprecate gutenberg_get_block_categories (#13454)
  Plugin: Deprecate gutenberg_content_block_version (#13469)
  API Fetch: Expose nonce on created middleware function (#13451)
  Plugin: Remove list screens integrations (#13459)
  Plugin: Remove core-defined block detection functions (#13467)
  Spec Parser: Move generated spec parser to package (#13493)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment