New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Remove PHPUnit tests covering core functions #13513

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Projects
2 participants
@aduth
Copy link
Member

aduth commented Jan 25, 2019

This pull request seeks to remove PHPUnit test suites covering functions provided by WordPress core.

This includes coverage for:

  • WP_Block_Type_Registry (class-block-type-registry-test.php)
  • WP_Block_Type (class-block-type-test.php)
  • do_blocks (class-do-blocks-test.php, class-dynamic-blocks-render-test.php, class-reusable-blocks-render-test.php)
  • parse_blocks (class-performance-test.php)
  • register_block_type, unregister_block_type, get_dynamic_block_names (class-registration-test.php)

See: https://github.com/WordPress/wordpress-develop/tree/master/tests/phpunit/tests/blocks

Testing instructions:

Verify tests pass:

npm test

@aduth aduth added this to In Progress in Remove PHP via automation Jan 25, 2019

@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

LGTM 👍

@aduth aduth merged commit cea6957 into master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 28, 2019

@aduth aduth deleted the remove/php-unit-tests branch Jan 28, 2019

daniloercoli added a commit that referenced this pull request Jan 28, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-move-title-to-rich-text

* 'master' of https://github.com/WordPress/gutenberg:
  Adds undo/redo support for the title. (#13514)
  Fix typo (#13524)
  RichText: List: Fix indent/outdent (#12667)
  Fixes tense on verb “assign” to correct tense (#13541)
  Plugin: Deprecate metabox supports, fall back to core (#13449)
  Rnmobile/upload media file (#13128)
  Plugin: Remove redundant core compatibility from plugin (#13442)
  Testing: Remove PHPUnit tests covering core functions (#13513)
  Plugin: Deprecate gutenberg_add_gutenberg_post_state (#13471)

@aduth aduth added this to the 5.0 (Gutenberg) milestone Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment