New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Adds undo/redo support for the title. #13514

Merged
merged 2 commits into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@diegoreymendez
Copy link
Contributor

diegoreymendez commented Jan 25, 2019

Description

Adds undo / redo support for native.

How has this been tested?

This should be tested through the following PR: wordpress-mobile/gutenberg-mobile#501

Types of changes

Simply adds back some code from post-title/index.js into post-title/index.native.js.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@diegoreymendez diegoreymendez self-assigned this Jan 25, 2019

@diegoreymendez diegoreymendez requested a review from daniloercoli Jan 25, 2019

@diegoreymendez diegoreymendez changed the title Adds undo/redo support for the title. Mobile: Adds undo/redo support for the title. Jan 25, 2019

@daniloercoli
Copy link
Contributor

daniloercoli left a comment

Looks good!

@diegoreymendez diegoreymendez merged commit b598fb3 into master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@diegoreymendez diegoreymendez deleted the rnmobile/372-writing-flow-add-back-undo-redo-support-2 branch Jan 28, 2019

daniloercoli added a commit that referenced this pull request Jan 28, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-move-title-to-rich-text

* 'master' of https://github.com/WordPress/gutenberg:
  Adds undo/redo support for the title. (#13514)
  Fix typo (#13524)
  RichText: List: Fix indent/outdent (#12667)
  Fixes tense on verb “assign” to correct tense (#13541)
  Plugin: Deprecate metabox supports, fall back to core (#13449)
  Rnmobile/upload media file (#13128)
  Plugin: Remove redundant core compatibility from plugin (#13442)
  Testing: Remove PHPUnit tests covering core functions (#13513)
  Plugin: Deprecate gutenberg_add_gutenberg_post_state (#13471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment