New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isShallowEqual documentation and unit tests by deep comparison #13526

Merged
merged 2 commits into from Jan 28, 2019

Conversation

Projects
None yet
2 participants
@Naerriel
Copy link
Contributor

Naerriel commented Jan 26, 2019

Description

This PR solves #7801.
It updates isShallowEqual documentation and unit tests by deep comparison.

How has this been tested?

Ran npm run test.

Screenshots

Types of changes

Update of documentation
Update of unit tests

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@aduth
Copy link
Member

aduth left a comment

Thanks for this. I really like the idea of providing a contrasted description from deep equality, and in ensuring via testing that the module doesn't accidentally implement deep equality.

Show resolved Hide resolved packages/is-shallow-equal/README.md Outdated
Update packages/is-shallow-equal/README.md
Co-Authored-By: Naerriel <naerriel@gmail.com>
@aduth

aduth approved these changes Jan 28, 2019

Copy link
Member

aduth left a comment

Thanks for the improvement 👍

@aduth aduth merged commit 98b1350 into WordPress:master Jan 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment