New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update links #13531

Merged
merged 10 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@ajitbohra
Copy link
Member

ajitbohra commented Jan 27, 2019

Updates links across docs for consitency.

Ref:
https://wordpress.org/gutenberg/handbook/contributors/document/#using-links

@ajitbohra ajitbohra requested a review from gziolo Jan 27, 2019

@chrisvanpatten

This comment has been minimized.

Copy link
Member

chrisvanpatten commented Jan 27, 2019

🙌

@gziolo
Copy link
Member

gziolo left a comment

I shared some suggestions on how to fix the broken links I found.

Show resolved Hide resolved test/integration/full-content/fixtures/README.md Outdated
Show resolved Hide resolved ...rs/developers/tutorials/sidebar-tutorial/plugin-sidebar-5-update-meta.md Outdated
Show resolved Hide resolved test/integration/full-content/fixtures/README.md Outdated
Show resolved Hide resolved ...velopers/tutorials/sidebar-tutorial/plugin-sidebar-4-initialize-input.md Outdated
Show resolved Hide resolved ...velopers/tutorials/sidebar-tutorial/plugin-sidebar-4-initialize-input.md Outdated
Show resolved Hide resolved ...opers/tutorials/sidebar-tutorial/plugin-sidebar-2-styles-and-controls.md Outdated
Show resolved Hide resolved ...developers/tutorials/sidebar-tutorial/plugin-sidebar-1-up-and-running.md Outdated
@@ -66,7 +66,7 @@ The core provided categories are:
category: 'widgets',
```

Plugins and Themes can also register [custom block categories](../docs/extensibility/extending-blocks/#managing-block-categories).
Plugins and Themes can also register [custom block categories](/docs/extensibility/extending-blocks/#managing-block-categories).

This comment has been minimized.

@gziolo

gziolo Jan 28, 2019

Member

All link updated in this file seem to be outdated.

This comment has been minimized.

@ajitbohra

ajitbohra Jan 28, 2019

Author Member

yes, it's referring to the old structure.

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Jan 28, 2019

Nice one @ajitbohra - it would be great to land it soon to have one way to link everywhere 💯

gziolo and others added some commits Jan 28, 2019

Update link
Co-Authored-By: ajitbohra <ajit@lubus.in>
Update link
Co-Authored-By: ajitbohra <ajit@lubus.in>
Update link
Co-Authored-By: ajitbohra <ajit@lubus.in>
Update link
Co-Authored-By: ajitbohra <ajit@lubus.in>
Update link
Co-Authored-By: ajitbohra <ajit@lubus.in>
@ajitbohra

This comment has been minimized.

Copy link
Member Author

ajitbohra commented Jan 28, 2019

@gziolo refactored links at few more places & fixed dead links across docs. We have been referring to the old structure.

@@ -62,7 +62,7 @@ This will generate 4 files inside the `movies` plugin directory. All files conta
* Registers all block assets so that they can be enqueued through Gutenberg in
* the corresponding context.
*
* @see https://wordpress.org/gutenberg/handbook/blocks/writing-your-first-block-type/#enqueuing-block-scripts
* @see https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/block-tutorial/writing-your-first-block-type/

This comment has been minimized.

@gziolo

gziolo Jan 29, 2019

Member

We should backport those changes to WP-CLI, too :)

This comment has been minimized.

@ajitbohra

gziolo added some commits Jan 29, 2019

@gziolo

gziolo approved these changes Jan 29, 2019

Copy link
Member

gziolo left a comment

I addressed my own comments in commits :)

Great work on this one. Thank you very much for leading those efforts 💯

Show resolved Hide resolved docs/contributors/scripts.md Outdated
Show resolved Hide resolved docs/contributors/scripts.md Outdated

@gziolo gziolo merged commit 9e523ce into master Jan 29, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gziolo gziolo deleted the docs/update-links branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment