New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Avoid setting generic "Edit Post" title on load #13552

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
3 participants
@aduth
Copy link
Member

aduth commented Jan 28, 2019

Previously: #8831 (786de1e)

This pull request seeks to remove special handling for the admin screen's <title> element by Gutenberg. As part of removing client-side title handling in #8831, logic was added to explicitly assign "Edit Post" (or as defined by custom post type label) as the title of the screen, regardless whether the user was adding a new post or editing an existing one. Presumably this was added to account for the fact that due to the lack of full page reload on save, a user would seamlessly transition from the state of adding a new post to editing an existing one.

However, this behavior was never incorporated into WordPress 5.0, and in retrospect, I don't know that it adds much value. To me, there is likely to be little confusion caused from a user seeing "Add New Post" in the title of a screen if they had in-fact started their editing session by creating a new post. In any case, an enhancement here should probably be proposed to core proper, as most PHP is being removed from the Gutenberg plugin when deferring to core is possible.

Testing instructions:

Verify that page titles of the post editor, both in adding a new post and editing an existing one, align between the Gutenberg plugin and in the block editor provided through WordPress 5.0.

Specifically, a new post should show "Add New Post", and editing an existing post should show "Edit Post".

@aduth aduth requested a review from danielbachhuber Jan 28, 2019

@aduth aduth added this to In Progress in Remove PHP via automation Jan 28, 2019

@danielbachhuber
Copy link
Member

danielbachhuber left a comment

However, this behavior was never incorporated into WordPress 5.0, and in retrospect, I don't know that it adds much value. To me, there is likely to be little confusion caused from a user seeing "Add New Post" in the title of a screen if they had in-fact started their editing session by creating a new post. In any case, an enhancement here should probably be proposed to core proper, as most PHP is being removed from the Gutenberg plugin when deferring to core is possible.

Fair enough. I started creating a core ticket just now to port this over but, when I reviewed the current behavior, I agree with your assessment. We can leave the existing behavior as-is.

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 29, 2019

@aduth aduth merged commit 5f2c25d into master Jan 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 29, 2019

@aduth aduth deleted the remove/generic-title branch Jan 29, 2019

daniloercoli added a commit that referenced this pull request Jan 30, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (36 commits)
  Fixes plural messages POT generation. (#13577)
  Typo fix (#13595)
  REST API: Remove oEmbed proxy HTML filtering (#13575)
  Removed unnecessary className attribute. Fixes #11664 (#11831)
  Add changelog for RSS block (#13588)
  Components: Set type=button for TabPanel button elements. (#11944)
  Update util.js (#13582)
  Docs: Add accessbility specific page (#13169)
  Rnmobile/media methods refactor (#13554)
  chore(release): publish
  chore(release): publish
  Plugin: Deprecate gutenberg_get_script_polyfill (#13536)
  Block API: Parse entity only when valid character reference (#13512)
  RichText: List: fix indentation (#13563)
  Plugin: Deprecate window._wpLoadGutenbergEditor (#13547)
  Plugin: Avoid setting generic "Edit Post" title on load (#13552)
  Plugin: Populate demo content by default content filters (#13553)
  RichText: List: Fix getParentIndex (#13562)
  RichText: List: Fix outdent with children (#13559)
  Scripts: Remove npm run build from test-e2e default run (#13420)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment