New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API: Remove oEmbed proxy HTML filtering #13575

Merged
merged 3 commits into from Jan 30, 2019

Conversation

@aduth
Copy link
Member

aduth commented Jan 29, 2019

Related: https://github.com/WordPress/gutenberg/pull/9734/files#r252005662
Related: #13408

This pull request seeks to remove Gutenberg's filtering of the oEmbed proxy endpoint responsible for filtering HTML from the response. This was implemented as part of the following Trac ticket and corresponding changeset:

Per #9734, the function serves a secondary purpose of handling a failing oEmbed proxy request which could be handled as a shortcode. This was never merged as part of the WordPress 5.0 release, and thus has been left as an extension provided by Gutenberg. The task to bring this in core can be found at the following link:

In the meantime, the function gutenberg_filter_oembed_result has been paired down to include only this specific handling.

Testing instructions:

Repeat testing instructions from #9734

@aduth aduth added this to In Progress in Remove PHP via automation Jan 29, 2019

@aduth aduth requested review from pento and notnownikki Jan 29, 2019

@notnownikki
Copy link
Member

notnownikki left a comment

Tested with WordPress 5.0.3 and Jetpack 6.9, all works as expected. Responses from shortcode embeds remain the same, all looks good.

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 30, 2019

@aduth aduth merged commit 62e1522 into master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 30, 2019

@youknowriad youknowriad deleted the remove/rest-api-oembed-proxy-filter branch Jan 30, 2019

daniloercoli added a commit that referenced this pull request Jan 30, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg: (36 commits)
  Fixes plural messages POT generation. (#13577)
  Typo fix (#13595)
  REST API: Remove oEmbed proxy HTML filtering (#13575)
  Removed unnecessary className attribute. Fixes #11664 (#11831)
  Add changelog for RSS block (#13588)
  Components: Set type=button for TabPanel button elements. (#11944)
  Update util.js (#13582)
  Docs: Add accessbility specific page (#13169)
  Rnmobile/media methods refactor (#13554)
  chore(release): publish
  chore(release): publish
  Plugin: Deprecate gutenberg_get_script_polyfill (#13536)
  Block API: Parse entity only when valid character reference (#13512)
  RichText: List: fix indentation (#13563)
  Plugin: Deprecate window._wpLoadGutenbergEditor (#13547)
  Plugin: Avoid setting generic "Edit Post" title on load (#13552)
  Plugin: Populate demo content by default content filters (#13553)
  RichText: List: Fix getParentIndex (#13562)
  RichText: List: Fix outdent with children (#13559)
  Scripts: Remove npm run build from test-e2e default run (#13420)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment