New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image settings button #13597

Merged
merged 2 commits into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@etoledom
Copy link
Contributor

etoledom commented Jan 30, 2019

Description

This PR exports InspectorControls to be used on Mobile.
Using this, the Image Settings button is added to the image block to be displayed in the inline toolbar.

This is the simpler first step for wordpress-mobile/gutenberg-mobile#202

Screenshots

simulator screen shot - iphone x - 2019-01-30 at 14 47 46

To test:

@Tug

Tug approved these changes Jan 30, 2019

Copy link
Contributor

Tug left a comment

LGTM 👍

@etoledom etoledom merged commit a85767a into master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@etoledom etoledom deleted the rnmobile/image-settings-button branch Jan 30, 2019

daniloercoli added a commit that referenced this pull request Feb 1, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg:
  Try alternate list item jump fix. (#12941)
  Mobile bottom sheet component (#13612)
  Remove unintentional right-margin on last odd-item. (#12199)
  Introduce left and right float alignment options to latest posts block (#8814)
  Fix Google Docs table paste (#13543)
  Increase bottom padding on gallery image caption (#13623)
  Fix the editor save keyboard shortcut not working in code editor view (#13159)
  Plugin: Deprecate gutenberg_add_admin_body_class (#13572)
  Rnmobile/upload media failed state (#13615)
  Make clickOnMoreMenuItem not dependent on aria labels (#13166)
  Add: className prop support to server side render. (#13568)
  Fix: Categories Block: hierarchical Dropdown (#13567)
  Docs: Add clarification about git workflow (#13534)
  Plugin: Remove `user_can_richedit` filtering (#13608)
  eslint-plugin: Add rule `no-unused-vars-before-return` (#12828)
  Image settings button (#13597)
  Fixed wording for the color picker saturation (#13479)

# Conflicts:
#	packages/block-library/src/image/edit.native.js

@youknowriad youknowriad added this to the 5.0 (Gutenberg) milestone Feb 4, 2019

@etoledom etoledom referenced this pull request Feb 7, 2019

Open

Image settings #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment