New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Remove `user_can_richedit` filtering #13608

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
2 participants
@aduth
Copy link
Member

aduth commented Jan 30, 2019

Related: #13569
Related: #5670 (comment)
Related: #12151
Related: #12000

This pull request seeks to remove Gutenberg filtering originally introduced in #5670 to resolve an issue where an error could occur with the Classic Block when a user disabled the Visual Editing mode (#5667). This was later addressed by building in native handling for the setting to Gutenberg as part of #12151 (a previous attempt at #12000). Thus, the filter removed here is not necessary, and is in-fact not part of the core implementation of the block editor introduced with WordPress 5.0 (reference).

Testing instructions:

Verify against regressions of #5667, #12148

Repeat testing instructions from #12151

@aduth aduth added this to In Progress in Remove PHP via automation Jan 30, 2019

@aduth aduth requested review from mcsf , youknowriad and noisysocks Jan 30, 2019

@mcsf

mcsf approved these changes Jan 30, 2019

Copy link
Contributor

mcsf left a comment

Looks pretty clean and in parity with core.

I tested a bunch of combinations with Classic and other blocks, with and without the Gutenberg plugin, with ACF and a field present, and toggling the Disable visual editor setting. No issues spotted.

@aduth aduth merged commit 3fd2218 into master Jan 30, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Remove PHP automation moved this from In Progress to Done Jan 30, 2019

@aduth aduth deleted the remove/user-can-richedit-filter branch Jan 30, 2019

daniloercoli added a commit that referenced this pull request Feb 1, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg:
  Try alternate list item jump fix. (#12941)
  Mobile bottom sheet component (#13612)
  Remove unintentional right-margin on last odd-item. (#12199)
  Introduce left and right float alignment options to latest posts block (#8814)
  Fix Google Docs table paste (#13543)
  Increase bottom padding on gallery image caption (#13623)
  Fix the editor save keyboard shortcut not working in code editor view (#13159)
  Plugin: Deprecate gutenberg_add_admin_body_class (#13572)
  Rnmobile/upload media failed state (#13615)
  Make clickOnMoreMenuItem not dependent on aria labels (#13166)
  Add: className prop support to server side render. (#13568)
  Fix: Categories Block: hierarchical Dropdown (#13567)
  Docs: Add clarification about git workflow (#13534)
  Plugin: Remove `user_can_richedit` filtering (#13608)
  eslint-plugin: Add rule `no-unused-vars-before-return` (#12828)
  Image settings button (#13597)
  Fixed wording for the color picker saturation (#13479)

# Conflicts:
#	packages/block-library/src/image/edit.native.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment