New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase bottom padding on gallery image caption #13623

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@kjellr
Copy link
Contributor

kjellr commented Jan 31, 2019

Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.

(This is a mirror of #8459 by @johnwatkins0, but with the addition of the gradient background edit).

Before:

screen shot 2019-01-31 at 2 30 54 pm

After:

screen shot 2019-01-31 at 2 30 54 pm

Increase bottom padding on gallery image caption
Resolves #8018 by increasing the bottom padding of gallery image captions by 4px. Also increases the coverage of our gradient background by 10% to help with text contrast.
@gziolo

gziolo approved these changes Feb 1, 2019

Copy link
Member

gziolo left a comment

Looks nicer, thanks for taking care of this PR 👍

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Feb 1, 2019

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Feb 1, 2019

Yerp. Ship it.

@gziolo gziolo merged commit 2009bdd into master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/increase-bottom-padding-on-gallery-image-caption branch Feb 1, 2019

daniloercoli added a commit that referenced this pull request Feb 1, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg:
  Try alternate list item jump fix. (#12941)
  Mobile bottom sheet component (#13612)
  Remove unintentional right-margin on last odd-item. (#12199)
  Introduce left and right float alignment options to latest posts block (#8814)
  Fix Google Docs table paste (#13543)
  Increase bottom padding on gallery image caption (#13623)
  Fix the editor save keyboard shortcut not working in code editor view (#13159)
  Plugin: Deprecate gutenberg_add_admin_body_class (#13572)
  Rnmobile/upload media failed state (#13615)
  Make clickOnMoreMenuItem not dependent on aria labels (#13166)
  Add: className prop support to server side render. (#13568)
  Fix: Categories Block: hierarchical Dropdown (#13567)
  Docs: Add clarification about git workflow (#13534)
  Plugin: Remove `user_can_richedit` filtering (#13608)
  eslint-plugin: Add rule `no-unused-vars-before-return` (#12828)
  Image settings button (#13597)
  Fixed wording for the color picker saturation (#13479)

# Conflicts:
#	packages/block-library/src/image/edit.native.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment