New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hide teaser help text in More block. #13630

Merged
merged 2 commits into from Feb 1, 2019

Conversation

@gziolo
Copy link
Member

gziolo commented Feb 1, 2019

Description

Replaces #6561 which was started by @samikeijonen.

Adds Hide teaser help text in More block as mentioned in #2146.

This implementation is based on feedback shared by @afercia in #8974 (comment):

The help text has been changed in #11587, but still not so clear:

More
Mark the excerpt of this content.
Content before this block will be
shown in the excerpt on your
archives page.


Hide the teaser before the "More" tag

I'd like to suggest to change it into:

More
Content before this block will be
shown in the excerpt on your
archive pages.


Hide the excerpt on the full content page

#6561 (comment):

I'd like to propose something along the lines of the screenshot below:

screenshot 2018-12-28 at 14 44 09

As discussed at length during the implementation of the switch toggle, for better accessibility:

  • an UI control accessible name (the label) should not change dynamically
  • the state should indicated separately: a textual representation of the state is the only guarantee this information can be perceived by everyone

Screenshots

screen shot 2019-02-01 at 08 35 20
screen shot 2019-02-01 at 08 35 25

@gziolo gziolo requested a review from afercia Feb 1, 2019

@gziolo gziolo added this to the 5.1 (Gutenberg) milestone Feb 1, 2019

@gziolo gziolo referenced this pull request Feb 1, 2019

Closed

Add Hide teaser help text in More block #6561

3 of 4 tasks complete
@jorgefilipecosta
Copy link
Member

jorgefilipecosta left a comment

Code wise looks good to me and worked well in my tests 👍

@gziolo gziolo merged commit 5134fcf into master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the pr/6561 branch Feb 1, 2019

@samikeijonen

This comment has been minimized.

Copy link
Contributor

samikeijonen commented Feb 1, 2019

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment