Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMobile: BottomSheet design tweaks #13633
Conversation
etoledom
added some commits
Jan 30, 2019
etoledom
added
the
[Component] Mobile
label
Feb 1, 2019
etoledom
self-assigned this
Feb 1, 2019
etoledom
requested a review
from
marecar3
Feb 1, 2019
etoledom
merged commit c336500
into
master
Feb 1, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
etoledom
deleted the
rnmobile/bottom-sheet-design-tweaks
branch
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
Thank you! |
youknowriad
added this to the 5.0 (Gutenberg) milestone
Feb 4, 2019
Feb 4, 2019
This was referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
etoledom commentedFeb 1, 2019
•
edited
Description
This PR adds some design options to the BottomSheet and its Cells.
To test:
gutenberg-mobile
PR: (wordpress-mobile/gutenberg-mobile#533)