New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: BottomSheet design tweaks #13633

Merged
merged 28 commits into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@etoledom
Copy link
Contributor

etoledom commented Feb 1, 2019

Description

This PR adds some design options to the BottomSheet and its Cells.

  • A new option for a cell with just one Label with centered text.
  • A possibility to add custom styles to both Label and Value text.
  • A new option for adding an icon to the cell.
  • A possibility to completely hide the BottomSheet header.
  • A new separator with an option for not showing it (helpful for the last cell).

screen shot 2019-02-01 at 10 59 02 am

To test:

  • Checkout the related gutenberg-mobile PR: (wordpress-mobile/gutenberg-mobile#533)
  • Run the example project.
  • Tap on a image block with image.
  • Tap on the image settings button (the wheel icon in the inline toolbar).
  • Check that the BottomSheet displays as shown in the screenshot (with just one Alt text cell).
  • If you feel like it, play with different configurations for the BottomSheet and the Cells.

etoledom added some commits Jan 30, 2019

@etoledom etoledom self-assigned this Feb 1, 2019

@etoledom etoledom requested a review from marecar3 Feb 1, 2019

@marecar3
Copy link
Contributor

marecar3 left a comment

LGTM!

@etoledom etoledom merged commit c336500 into master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@etoledom etoledom deleted the rnmobile/bottom-sheet-design-tweaks branch Feb 1, 2019

@etoledom

This comment has been minimized.

Copy link
Contributor Author

etoledom commented Feb 1, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment