Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile BottomSheet: Adding max-width and centering. #13882

Merged
merged 8 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@etoledom
Copy link
Contributor

etoledom commented Feb 14, 2019

Description

This PR implements wordpress-mobile/gutenberg-mobile#572

centered-bottom-sheet
simulator screen shot - ipad pro 9 7-inch - 2019-02-14 at 16 45 25

This PR doesn't contemplate the space between the bottom of the screen and the BottomSheet.
Don't worry about the separators going out of the bottom sheet. That is resolved here: #13855

To test:

  • Checkout the related gutenberg-mobile PR (wordpress-mobile/gutenberg-mobile#600)
  • Run the project on iOS and on Android.
  • Open the Image settings from an image block.
  • If you are running on an iPhone on portrait mode, turn it to landscape.
  • Check that the bottom sheet is not covering the full width on "wide" screens.
    • Considered wide: Any phone on landscape, any tablet.

@etoledom etoledom requested a review from pinarol Feb 19, 2019

@pinarol
Copy link
Contributor

pinarol left a comment

Tested with gb-mobile PR, works and looks all good 🎉

@etoledom etoledom merged commit 2df40d8 into master Feb 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@etoledom

This comment has been minimized.

Copy link
Contributor Author

etoledom commented Feb 19, 2019

Thank you!

@etoledom etoledom deleted the rnmobile/bottom-sheet-width-centered branch Feb 19, 2019

mukeshpanchal27 added a commit to mukeshpanchal27/gutenberg that referenced this pull request Feb 26, 2019

Mobile BottomSheet: Adding max-width and centering. (WordPress#13882)
* Mobile BottomSheet: Adding max-width and centering.

* Mobile BottomSheet: Fixed drag indicator width.

* Mobile BottomSheet: Fix max-width on Android.

* Mobile BottomSheet: Added children container.

* Mobile BottomSheet: Added function to get bottom-sheet width

* Fix lint issues

@youknowriad youknowriad added this to the 5.2 (Gutenberg) milestone Mar 4, 2019

youknowriad added a commit that referenced this pull request Mar 6, 2019

Mobile BottomSheet: Adding max-width and centering. (#13882)
* Mobile BottomSheet: Adding max-width and centering.

* Mobile BottomSheet: Fixed drag indicator width.

* Mobile BottomSheet: Fix max-width on Android.

* Mobile BottomSheet: Added children container.

* Mobile BottomSheet: Added function to get bottom-sheet width

* Fix lint issues

youknowriad added a commit that referenced this pull request Mar 6, 2019

Mobile BottomSheet: Adding max-width and centering. (#13882)
* Mobile BottomSheet: Adding max-width and centering.

* Mobile BottomSheet: Fixed drag indicator width.

* Mobile BottomSheet: Fix max-width on Android.

* Mobile BottomSheet: Added children container.

* Mobile BottomSheet: Added function to get bottom-sheet width

* Fix lint issues

mkevins added a commit to mkevins/gutenberg that referenced this pull request Mar 26, 2019

Mobile BottomSheet: Adding max-width and centering. (WordPress#13882)
* Mobile BottomSheet: Adding max-width and centering.

* Mobile BottomSheet: Fixed drag indicator width.

* Mobile BottomSheet: Fix max-width on Android.

* Mobile BottomSheet: Added children container.

* Mobile BottomSheet: Added function to get bottom-sheet width

* Fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.