Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile BottomSheet: Adding max-width and centering. #13882

Merged
merged 8 commits into from Feb 19, 2019
Merged

Mobile BottomSheet: Adding max-width and centering. #13882

merged 8 commits into from Feb 19, 2019

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Feb 14, 2019 •
edited

Description

This PR implements wordpress-mobile/gutenberg-mobile#572

centered-bottom-sheet
simulator screen shot - ipad pro 9 7-inch - 2019-02-14 at 16 45 25

This PR doesn't contemplate the space between the bottom of the screen and the BottomSheet.
Don't worry about the separators going out of the bottom sheet. That is resolved here: #13855

To test:

  • Checkout the related gutenberg-mobile PR (BottomSheet centered with maximum width. wordpress-mobile/gutenberg-mobile#600)
  • Run the project on iOS and on Android.
  • Open the Image settings from an image block.
  • If you are running on an iPhone on portrait mode, turn it to landscape.
  • Check that the bottom sheet is not covering the full width on "wide" screens.
    • Considered wide: Any phone on landscape, any tablet.

@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Feb 14, 2019
@etoledom etoledom self-assigned this Feb 14, 2019
@etoledom etoledom mentioned this pull request Feb 14, 2019
Merged
pinarol
pinarol approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with gb-mobile PR, works and looks all good 🎉

@etoledom etoledom merged commit 2df40d8 into master Feb 19, 2019
@etoledom
Copy link
Contributor Author

Thank you!

@etoledom etoledom deleted the rnmobile/bottom-sheet-width-centered branch February 19, 2019 09:46
@youknowriad youknowriad added this to the 5.2 (Gutenberg) milestone Mar 4, 2019
@ellatrix ellatrix mentioned this pull request Mar 4, 2019
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@etoledom @youknowriad
Mobile BottomSheet: Adding max-width and centering. (#13882)
03749b3 
* Mobile BottomSheet: Adding max-width and centering.

* Mobile BottomSheet: Fixed drag indicator width.

* Mobile BottomSheet: Fix max-width on Android.

* Mobile BottomSheet: Added children container.

* Mobile BottomSheet: Added function to get bottom-sheet width

* Fix lint issues
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@etoledom @youknowriad
Mobile BottomSheet: Adding max-width and centering. (#13882)
7cacc9a 
* Mobile BottomSheet: Adding max-width and centering.

* Mobile BottomSheet: Fixed drag indicator width.

* Mobile BottomSheet: Fix max-width on Android.

* Mobile BottomSheet: Added children container.

* Mobile BottomSheet: Added function to get bottom-sheet width

* Fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees

@etoledom etoledom

Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
5.2 (Gutenberg)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etoledom @pinarol @youknowriad