New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML block with preview. #1391

Merged
merged 7 commits into from Jun 23, 2017

Conversation

5 participants
@mtias
Copy link
Contributor

mtias commented Jun 23, 2017

image

Closes #1386.

jasmussen and others added some commits Jun 23, 2017

Polish the controls a bit.
We'll want to separate these out.
<div>
{ focus &&
<BlockControls key="controls">
<ul className="components-toolbar">

This comment has been minimized.

@youknowriad

youknowriad Jun 23, 2017

Contributor

Can't we use the regular Toolbar component for this? I guess we just need to make the icon optional and drop the fixed width?

This comment has been minimized.

@mtias

mtias Jun 23, 2017

Author Contributor

It forces icon at the moment. And we'll probably just create a segmented-control out of this in any case.

This comment has been minimized.

@youknowriad

youknowriad Jun 23, 2017

Contributor

as part of #1256 I updated the Toolbar component to allow this. Edit: I updated the styling only. but seems easy to drop the icon requirement

This comment has been minimized.

@youknowriad

youknowriad Jun 23, 2017

Contributor

Could be done separately of course

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Jun 23, 2017

Designed new icon for the block here: WordPress/dashicons#207

@mtias mtias force-pushed the add/html-block branch from 41683d2 to 98472d1 Jun 23, 2017

@youknowriad
Copy link
Contributor

youknowriad left a comment

Works great, feel free to merge when the tests are fixed

@iseulde

This comment has been minimized.

Copy link
Member

iseulde commented Jun 23, 2017

Awesome!

@mtias mtias merged commit e8a09d7 into master Jun 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@iseulde iseulde deleted the add/html-block branch Jul 2, 2017

@afercia afercia added the Widgets label Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment